Add semantic labels to `MsgColors enum` in `msgwindow.h`.
COLOR_RED → COLOR_ERROR (geany-compiler-error) COLOR_DARK_RED → COLOR_CONTEXT (geany-compiler-context) COLOR_BLACK → COLOR_TEXT COLOR_BLUE → COLOR_MESSAGE (geany-compiler-message)
Documentation referring to "orange" won't be accurate until after #3013 is merged. Opening PR now to allow more time for review.
Resolves #3016. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3017
-- Commit Summary --
* Add semantic labels to MsgColors enum in msgwindow.h
-- File Changes --
M src/build.c (10) M src/msgwindow.c (12) M src/msgwindow.h (20) M src/plugindata.h (2) M src/search.c (16)
-- Patch Links --
https://github.com/geany/geany/pull/3017.patch https://github.com/geany/geany/pull/3017.diff
LGBI, havn't tried it, anyone feel free to beat me to it.
@xiota pushed 1 commit.
82e390f2e8be3ce7aeb575a7fbe6901f087f2a5c Add comment to note deprecation date
@elextr commented on this pull request.
@@ -38,7 +38,7 @@ enum MsgColors
COLOR_TEXT, /**< Color for normal text. Default is black. */ COLOR_MESSAGE, /**< Color for ``geany-compiler-message``. Default is blue. */
-#ifndef GEANY_DISABLE_DEPRECATED +#ifndef GEANY_DISABLE_DEPRECATED /* 2021/11/24 */
Thats yesterday in my timezone :wink:
actually good point but better expressed as "since 1.40" (or whatever the next version is) in each doxygen comment
@xiota commented on this pull request.
@@ -38,7 +38,7 @@ enum MsgColors
COLOR_TEXT, /**< Color for normal text. Default is black. */ COLOR_MESSAGE, /**< Color for ``geany-compiler-message``. Default is blue. */
-#ifndef GEANY_DISABLE_DEPRECATED +#ifndef GEANY_DISABLE_DEPRECATED /* 2021/11/24 */
@elextr
Thats yesterday in my timezone wink
I did open this PR yesterday, but it probably wouldn't be merged until next week. I'll change the date to 2021/12. (Having a date would show how much time has passed without having to look for at a release history.)
better expressed as "since 1.40" (or whatever the next version is) in each doxygen comment
I'll add a version number.
Since we havn't yet decided the next version number (the milestone says 1.39/2.0) one way to avoid forgetting, but still allow this to be merged soon is to create another PR with milestone 1.39/2.0 which points to these doxycomments and says "Update to new version when its decided what it will be".
@xiota pushed 1 commit.
b326e8763dce0652b34da105595802b9f02c3411 Add deprecation version and API
Since we havn't yet decided the next version number (the milestone says 1.39/2.0) one way to avoid forgetting, but still allow this to be merged soon is to create another PR with milestone 1.39/2.0 which points to these doxycomments and says "Update to new version when its decided what it will be".
I don't know how to do that. / I am not able to add milestones to PRs.
I used 1.39. It's the number in the current config, so whenever that's updated, the other instances can be grepped.
I used 1.39. It's the number in the current config, so whenever that's updated, the other instances can be grepped.
Fair enough.
@xiota pushed 1 commit.
4cb29c2c9d1c7f96f556604ca873973708b62ae1 fix incorrect use of doxygen tag
Tested and works as expected. Also, G-P complain a lot with deprecation warnings (which is expected and good).
Fine to merge by me, @elextr just press the button if you agree.
github-comments@lists.geany.org