Just a suggestion. More rationale in the commit messages. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1148
-- Commit Summary --
* Remove COMMITTERS * Update AUTHORS * Remove TODO
-- File Changes --
M AUTHORS (7) D COMMITTERS (11) D TODO (45)
-- Patch Links --
https://github.com/geany/geany/pull/1148.patch https://github.com/geany/geany/pull/1148.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148
@@ -4,11 +4,14 @@ Developers: Nick Treleaven <nick(dot)treleaven(at)btinternet(dot)com> Colomban Wendling <lists(dot)ban(at)herbesfolles(dot)org>
@b4n Shouldn't the "lists." prefix in your email be removed here?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148/files/b1d9c5f3ed5e52dcb9558e391a83e...
mostly LGBI. a few TODO items might be interesting to be converted into some kind of issue, but indeed there's a fair bunch of outdated stuff.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-234805842
@@ -4,11 +4,14 @@ Developers: Nick Treleaven <nick(dot)treleaven(at)btinternet(dot)com> Colomban Wendling <lists(dot)ban(at)herbesfolles(dot)org>
probably yeah, as I don't use that email address anywhere else for Geany (in a visible fashion anyway)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148/files/b1d9c5f3ed5e52dcb9558e391a83e...
Travis rightly fails, TODO would also have to be removed from doc/Makefile.am
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-234805998
We could also remove `ChangeLog*` files.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-234807457
@codebrainz Is all the info from the old ChangeLog present in the original SVN (now git) messages? If not, it might still be useful e.g. when bisecting and the commit message isn't descriptive enough.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-234808441
I'd vote to keep `ChangeLog*` files. In the early days, I/we used to maintain the ChangeLog file a lot and maybe sometimes even more than CVS/SVN commit messages. So there could be potential data loss when they get deleted.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-238086364
Agreed.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-238092638
So there could be potential data loss when they get deleted.
The ChangLog.pre-1-22 is already in VCS, removing it won't retroactively remove it from all of history, though it would make it more hassle to look at it. In any case, we could remove [`ChangeLog`](https://github.com/geany/geany/blob/1.28.0/ChangeLog) as it contains nothing useful.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-238099343
Its unlikely that we would lose much by removing olde history files, its only used when searching really olde stuff, and thats not done very often, and then as @codebrainz says its still in the history of back when. So if you switch git back to a historical position you will get the changelog and other history files as well.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1148#issuecomment-238114970
What if we drop `ChangeLog.pre-1-22`, keep `ChangeLog` and add a note to it stating the GIT revision where ChangeLog.pre-1-22 can be found?
The rest looks fine to me.
What if we drop ChangeLog.pre-1-22, keep ChangeLog and add a note to it stating the GIT revision where ChangeLog.pre-1-22 can be found?
Sounds like a plan.
What if we drop ChangeLog.pre-1-22, keep ChangeLog and add a note to it stating the GIT revision where ChangeLog.pre-1-22 can be found?
I would still prefer keeping it. Apart from changelog it's an easy-to-access source of credits and "who did what" before git was introduced. After git, you can easily see all the contributors and their patches by selecting the "Contributors" link on github. If we remove the file and only link to a past commit which contains it, there won't be any easy way to access it while browsing github.
there won't be any easy way to access it while browsing github
What about saving bookmark in your browser to [a commit that contains it](https://github.com/geany/geany/blob/3303bde75844033e4262f649a3437e0dbcc316d0...
What about saving bookmark in your browser to a commit that contains it?
It's not because of me personally - I can of course copy-out the file, have it printed on a hand-made paper, have it leather-bound and read it every day before going to bed. But I think everyone should have an easy access to the file - it describes the history of Geany (and not all of the information is in the commits - e.g. the first few releases of Geany weren't version-controlled) and the same way we wouldn't remove old commits from the git repository, we shouldn't remove the changelog file IMO.
I'm saying this just because I don't want to make the change myself as I don't find it right. But feel free to create a separate pull request that removes the file - I'm definitely not going to block its merging if others think it should be removed.
github-comments@lists.geany.org