On filetypes common it says: "# translucency for the line marker(first argument) and the search marker (second argument) marker_translucency=255;255" However changing the 2nd argument does NOT affect search marker translucency. The proposed change addresses this.
On the downside: current hard-coded value of 60 (very transparent) would become filetypes.common's default of 255 (no transparency).
On the upside: 1) we would be consistent with what is indicated in filetypes.common about translucency for the search marker 2) this change may help all DARK themes, since marked words are barely visible no matter the GCS_MARKER_SEARCH background color used. By changing the translucency we can make them standout, just like in white themes. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1490
-- Commit Summary --
* Fix search marker translucency (currently ignoring scheme)
-- File Changes --
M src/highlighting.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/1490.patch https://github.com/geany/geany/pull/1490.diff
Agree its a problem worth solving,
The MARKER_TRANSLUCENCY background value has already been used for the translucency of a margin marker. It is probably better not to use it for two unrelated things, and not to change an existing usage.
I don't know where the comment in filetypes.common came from, the translucency has been fixed as far back as I looked (2010). The setting being used for a margin marker may be a confusion between "mark", "marker" and "indicator" that is used as a marker.
The thing to do is to make a new setting adding it to `filetypes.common` as a named style with the default 60 and then using the named style in the styling section. Then colour schemes can change it to suit themselves.
Would probably be good to make `translucency` and `marker_translucency` named styles as well "while you are there" ;-).
github-comments@lists.geany.org