Hello,
This is the pull request for the Gibiane language support in Geany.
Sincerely,
Thibault LINDECKER, The Cast3M support. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2246
-- Commit Summary --
* Adding native support for the Gibiane language (http://www-cast3m.cea.fr)
-- File Changes --
M ctags/Makefile.am (3) M ctags/main/parsers.h (3) A ctags/parsers/GIBIANE.c (352) M data/Makefile.am (6) A data/filedefs/filetypes.gibiane (65) M data/filetype_extensions.conf (1) A data/tags/std.dgibi.tags (312) M scintilla/Makefile.am (3) M scintilla/include/SciLexer.h (14) M scintilla/include/Scintilla.iface (18) A scintilla/lexers/LexGIBIANE.cxx (377) M scintilla/src/Catalogue.cxx (1) A scripts/create_dgibi_tags.sh (32) M src/editor.c (24) M src/filetypes.c (1) M src/filetypes.h (1) M src/highlighting.c (6) M src/highlightingmappings.h (32) M src/symbols.c (2) M src/tagmanager/tm_parser.c (5) M src/tagmanager/tm_parser.h (1) M src/tagmanager/tm_workspace.c (7) M src/tagmanager/tm_workspace.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/2246.patch https://github.com/geany/geany/pull/2246.diff
I have a question, what do you think you will gain by having this in the Geany core, given that (AFAIK) none of the normal contributors normally have access to the toolset for the language, so we will not be able to support it much. So you will be maintaining it yourself anyway.
And given that it likely adds work for the Geany community of volunteers, what do they get out of it?
And given that it adds more code to everybodys copy of Geany, what do they get out of it?
On a practical note, as @codebrainz said on the mailing list, it is policy to have Scintilla lexers and ctags parsers added upstream first, Geany does not support its own copies (except historical ones). So you need to submit those parts upstream.
Hello,
For information, the Cast3M software is available for free with the "Education-Research" license (http://www-cast3m.cea.fr/index.php?page=dlcastem) and it is widely used by universities, students and companies all around the world. Note that it is not a "freenium" software. The paid version does not have more features, on the contrary, the user is more restricted but have guarantees...
If I make a pull request to scintilla and they accept, you think that you could integrate it on the Geany ?
In any case, I would like to thank all Geany development team for this very useful software.
Sincerely,
Thibault LINDECKER
@ThibLind to explain where I'm coming from some more.
In these days of corporate supported open source (go, rust etc) and academic supported open source (Julia etc) and open source projects with complex organisations (Debian etc) Geany is somewhat of an anachronism. Geany is just a bunch of people contributing in their own, mostly limited, time (sorry for the delay in replying BTW) and as such they work on what they are interested in, and limited to what they have time to do.
This means that there is no specific acceptance process, any contributions are "accepted" if somebody reviews, tests and merges them. It also means that there is almost never an absolute rejection of a PR either, well unless people really don't like it, then they complain loudly, but for most everybody thinks "just because I'm not interested or don't have time now does not mean somebody else will not become interested or have time tomorrow" so nobody outright rejects anything that they do not totally hate.
So I just want to make sure that this is understood and acceptable when your contribution is coming from an organisation that may have its own goals and schedules.
Also there are costs of time and effort to initially review, install the toolchain, learn the language, test, and merge. So support for uncommon languages tends to be slow to be merged and tends to not happen if Scintilla has not accepted the lexer or uctags has not accepted the parser (where appropriate).
Also there is then the question of ongoing maintenance. Will your organisation commit to maintaining the Scintilla, tags and Geany parts and supporting user questions/requests/problem reports? Since as I said I don't know of any Geany contributors who use your language, so support from regular Geany contributors is likely to be limited.
All this is not to discourage you from continuing, just to make sure you understand ahead of time.
Hello,
Thank you for your very detailed answer. I understand and I can't say that my organization will maintain it because it is a personal initiative. Personally, I can maintain it with at least one commit a year, after the new Cast3M version is released.
Thibault LINDECKER
@ThibLind Suggestion: Add these custom files to the wiki, than Geany users can always optionally load this file, while you still can edit your own page.
example https://wiki.geany.org/config/scss
github-comments@lists.geany.org