You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3096
-- Commit Summary --
* Fixing typos
-- File Changes --
M HACKING (2) M doc/geany.txt (6)
-- Patch Links --
https://github.com/geany/geany/pull/3096.patch https://github.com/geany/geany/pull/3096.diff
@deining the following has nothing to do with your changes AFAICT, they look fine.
@eht16 you are the Rest expert IIRC, looking at the check log for, binreloc=no, build action, lines 556-560 which appear to be from building the PDF manual, what are they??
The PR looks good to me, thanks @deining.
@eht16 you are the Rest expert IIRC,
Who said this? I don't think so :).
looking at the check log for, binreloc=no, build action, lines 556-560 which appear to be from building the PDF manual, what are they??
Not sure, I don't think I've seen those before. Just tested locally and there are no such messages (with Debian testing). The corresponding lines in `geany.txt` (line 1631 and following) are prefixed with a pipe. According to https://bashtage.github.io/sphinx-material/rst-cheatsheet/rst-cheatsheet.htm..., this creates a line block to ensure each line will be rendered a separate line.
Maybe it is just a specific version of rst2pdf in the build action environment which outputs these messages.
Just had a closer look at the line blocks: they render equally on HTML and PDF outputs and the intention was to have line breaks between the four lines. And as said, in current versions of `rst2pdf` this output is not present, so I guess this was rather some debugging output or similar in former `rst2pdf` versions. I would keep it as is. Even if not, we should discuss this in its own issue.
Merged #3096 into master.
github-comments@lists.geany.org