This is a two-parts fix required for usage with 2.0:
8cad88d72c343fd1091b6dab85ecb226c062a9da: Fix a crash when encountering an unknown tag type (e.g. locals) 3af0bf5117a1143b20286f5ee9fb0a2c35916d6b: Add support for locals, and do something useful with them by default.
Without the first one, triggering documentation generation when a local is the "current" symbol crashes the plugin (and thus Geany). Without the second one in addition, it's annoying because locals "catch" the generation request, although in most cases they should be skipped.
Both of these are particularly important with 2.0 because we now generate locals for purpose of improved scope completion, and thus we have a *lot* of them for parsers supporting it (e.g. the C and C++ one, which is the main default target of the plugin). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1294
-- Commit Summary --
* geanygendoc: Do not crash if documenting an unknown tag type * geanygendoc: Add support for local variables
-- File Changes --
M geanygendoc/data/filetypes/c.conf (5) M geanygendoc/docs/manual.rst (2) M geanygendoc/src/ggd-tag-utils.c (1) M geanygendoc/src/ggd.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1294.patch https://github.com/geany/geany-plugins/pull/1294.diff
LGBI.
@frlan note that this might warrant a point release, because basically using this plugin with 2.0 will crash geany (it might not, but it's effectively more likely to crash than not in real use)
Sorry I didn't catch that in time 😕
Merged #1294 into master.
@frlan do you plan on making a point-release, given the above-mentioned reasons?
I did not yet plan any – maybe a point-release of Geany would be useful, too – but we should do it.
github-comments@lists.geany.org