You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3453
-- Commit Summary --
* correction bug 3387
-- File Changes --
M src/document.c (7)
-- Patch Links --
https://github.com/geany/geany/pull/3453.patch https://github.com/geany/geany/pull/3453.diff
@ntrel commented on this pull request.
@@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, const gchar *utf8_fname)
gboolean ret; gboolean new_file;
+ // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars[MSG_TYPE_RESAVE] != NULL)
This should only be done when Save As is successful.
@Guiikcar commented on this pull request.
@@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, const gchar *utf8_fname)
gboolean ret; gboolean new_file;
+ // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars[MSG_TYPE_RESAVE] != NULL)
yeah its logic i m sry so do you think i just need to move my code into the if (new_file){ } thanks you for your feedback!
@ntrel commented on this pull request.
@@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, const gchar *utf8_fname)
gboolean ret; gboolean new_file;
+ // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars[MSG_TYPE_RESAVE] != NULL)
No problem, thanks for the PR. I think you need to check `if (ret && ...`.
@Guiikcar pushed 1 commit.
f27d52f7249c30549b947ccd10401b74567535ff check that the file is saved correctly
@Guiikcar commented on this pull request.
@@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, const gchar *utf8_fname)
gboolean ret; gboolean new_file;
+ // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars[MSG_TYPE_RESAVE] != NULL)
sorry for the time to response. Now i check than the file is save.
normaly all its ok!
Hi back! Do i need to do something else?
github-comments@lists.geany.org