Nothing more to say. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/882
-- Commit Summary --
* Cleanup: fixed usage of '#include "geanyplugin.h"'
-- File Changes --
M addons/src/addons.c (2) M addons/src/ao_blanklines.c (2) M addons/src/ao_colortip.c (2) M addons/src/ao_markword.c (2) M addons/src/ao_systray.c (2) M debugger/src/breakpoints.c (2) M debugger/src/callbacks.h (2) M debugger/src/dpaned.c (2) M debugger/src/markers.c (2) M debugger/src/markers.h (2) M debugger/src/tpage.c (2) M geanydoc/src/config.c (2) M geanydoc/src/geanydoc.c (2) M geanyextrasel/src/extrasel.c (2) M geanyinsertnum/src/insertnum.c (2) M geanylua/gsdlg.c (2) M geanynumberedbookmarks/src/geanynumberedbookmarks.c (2) M geanyprj/src/geanyprj.h (2) M keyrecord/src/keyrecord.c (2) M lineoperations/src/linefunctions.h (2) M lineoperations/src/lineoperations.c (2) M scope/src/common.h (2) M scope/src/plugme.c (2) M treebrowser/src/treebrowser.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/882.patch https://github.com/geany/geany-plugins/pull/882.diff
IIUC <> is for including system files, and despite its delusions of grandeur I don't think Geany is guaranteed to be in the list of system search directories.
https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html
I don't think Geany is guaranteed to be in the list of system search directories.
It is, by the build system.
From the link:
``` "#include "file" This variant is used for header files of your own program. ```
Sure GCC allows you to abuse the convention, but that doesn't mean you should.
#include <file>
This variant is used for system header files. It searches for a file named file in a standard list of system directories. You can prepend directories to this list with the -I option (see Invocation).
Isn't this the normal way to do it? The ```geanyplugin.h``` file is not part of geany-plugins but part of geany.
Isn't this the normal way to do it?
It is. `geanyplugin.h` is a system include provided by `libgeany`, not local to plugins.
Doesn't really matter if you use `""` or `<>`, the only difference is that `""` first looks in the location of the source file that is being compiled (I believe it's actually the working directory of the compiler), whereas `<>` looks only in paths provided on the command line and default include dirs (/usr/include) (`""` also looks in these paths).
So for geanyplugin.h you need the include path on the command line, so both `<>` and `""` are equally correct. But, by convention, you should prefer `<>` for headers that don't belong to your package, which is the case here.
Merged #882 into master.
github-comments@lists.geany.org