They introduced[1] a GtkBox between the GtkEntry and the GtkComboBox to add some magic in the layout computation.
[1] https://git.gnome.org/browse/gtk+/commit/?id=222c43fc60362eeb97ce2d5e3a5583a69a2e30ef You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/995
-- Commit Summary --
* ui-utils: Fix ui_path_box_new with GTK+ >= 3.20
-- File Changes --
M src/ui_utils.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/995.patch https://github.com/geany/geany/pull/995.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/995
@kugel- Better?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/995#issuecomment-208427956
@@ -1919,7 +1919,9 @@ GtkWidget *ui_path_box_new(const gchar *title, GtkFileChooserAction action, GtkE vbox = gtk_vbox_new(FALSE, 0); if (gtk_widget_get_parent(path_entry)) /* entry->parent may be a GtkComboBoxEntry */ {
GtkWidget *parent = gtk_widget_get_parent(path_entry);
GtkWidget *parent = path_entry, *next_parent;while ((next_parent = gtk_widget_get_parent(parent)) != NULL)parent = next_parent;
while at it doing something like that, we could simplify the code by always resolving the parent and using that, dropping the conditional here -- e.g. doing what this block does, but unconditionally. If the first `get_parent()` returns NULL, it's the same as the else block anyway.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/995/files/8539388b6e51dc932fafa21f4c4395...
Variables should be declared at the beginning, as per HACKING.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/995#issuecomment-210989696
LGTM.
On a slightly related note: perhaps we should deprecate this function and use glade for FIF.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/995#issuecomment-210991553
Merged #995.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/995#event-633659694
github-comments@lists.geany.org