See #3613. Some of the changes here make sense, some don't really but are still needed not to look terrible with Adwaita 43. See each commit for details.
@techee @eht16 that's kind of how it looks to dodge the Adwaita 43 issues I could see. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3614
-- Commit Summary --
* Use symbolic icons in entries * Use symbolic icons in build setup dialog clear buttons * Use symbolic icons for tab label close buttons * Add ui_image_menu_item_new_with_icon_name() * Add ui_button_new_with_icon_name() * Use symbolic icon for edit-clear icon * msgwin: Hack not to add a new string
-- File Changes --
M data/geany.glade (4) M src/build.c (6) M src/dialogs.c (2) M src/msgwindow.c (20) M src/notebook.c (2) M src/plugins.c (2) M src/ui_utils.c (40) M src/ui_utils.h (4)
-- Patch Links --
https://github.com/geany/geany/pull/3614.patch https://github.com/geany/geany/pull/3614.diff
This needs to be tested on a wide range of distros, not just Debian, and not just Gnome, Cinnamon, XFCE, etc and Windows.
This needs to be tested on a wide range of distros, not just Debian, and not just Gnome, Cinnamon, XFCE, etc and Windows.
I don't think it needs to be tested on all thinkable distributions (just tried briefly on macOS and it seems to work), it should work the same way everywhere.
On the other hand it's not just a few functions renaming and a few strings renaming as I thought it would be and we are just too close to the release (and too close to the midnight - at least those of us living in the correct hemisphere and time zone ;-) so I'd say better to postpone this after 2.0.
on all thinkable distributions
No, just Ubuntu, Mint, Arch probably. The point is that the change is relying on icon themes, and distros are the thing that provides them, and possibly differing sets on each desktop, as far as we can tell all but Debian Adwaita provide sensible `gtk-clear` icons (since nobody has complained), but do they provide sensible `edit-clear-symbolic` icons?
Without checking we just don't know.
postpone this after 2.0.
Agreed, until we are confident we won't break a whole lot of other systems to fix one.
too close to the midnight
Go to bed while I have breakfast :-)
Agreed, it grew way too out of hand to be merged less than 24 hours before the deadline. And I agree with @elextr that it likely requires more testing than just hoping every other distro is shipping a well-behaving theme (better behaving than Debian's Adwaita 43) by default, although @techee has a point that as the icons that please Adwaita are used by GTK itself, it's *likely* not to cause much trouble.
Anyway, on top of this some of the changes here I'm happy with, some I am not so much (as mentioned in the commit messages), so it's not even like it's obviously the right thing to do down the road.
Let's just cross fingers and hope Debian does something about it, and nobody else is shipping a broken Adwaita icon theme… or that none of our user actually use the broken ones. :crossed_fingers:
Let's just cross fingers and hope Debian does something about it, and nobody else is shipping a broken Adwaita icon theme… or that none of our user actually use the broken ones.
No chance unless Murphy goes on holidays :smiling_imp:
although @techee has a point that as the icons that please Adwaita are used by GTK itself, it's likely not to cause much trouble.
I was looking for this page (which I couldn't find yesterday) for stock icons and their replacements:
https://developer-old.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-...
This has been advised by GTK since 3.10 and many applications started using these icons in the meantime so I think we are pretty safe regarding the icons themselves. IMO it's mostly just a matter of using the correct GTK API (plus deprecating some plugin API like `ui_image_menu_item_new()` and having a substitute for it).
@techee yeah, but here just using the icon name won't solve it, you also need to use the symbolic version for the problematic icons.
@techee yeah, but here just using the icon name won't solve it, you also need to use the symbolic version for the problematic icons.
Ah, OK, I missed that. But then it's really a problem of the icon theme I think.
But then it's really a problem of the icon theme I think.
Yeah, so we need to get an idea that major distros provide something sane for `-symbolic`.
On this Mint (not the latest but still supported) `find /usr/share/icons -name "edit-clear-symbolic*" -print ` only finds anything in Adwaita. But `find /usr/share/icons -name "edit-clear*" -print` finds lots.
I've tried this patch on Fedora 38 with Adwaita-dark theme, and all icons are dark on dark: 
github-comments@lists.geany.org