You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1432
-- Commit Summary --
* Update Catalan translation
-- File Changes --
M po/ca.po (34)
-- Patch Links --
https://github.com/geany/geany/pull/1432.patch https://github.com/geany/geany/pull/1432.diff
b4n commented on this pull request.
Otherwise LGTM (not that I speak Catalan though, but I'll trust you on that)
@@ -1852,7 +1851,7 @@ msgstr "_Visualitza"
#: ../data/geany.glade.h:391 msgid "Change _Font..." -msgstr "Canvia el _tipus de lletra..." +msgstr "Canvia la _lletra..."
changing mnemonics isn't awesome, so 2 questions: 1. have you checked `l` isn't already used in that menu? 2. is the new mnemonic feeling more natural, or could/should you keep the `t` one? (as *lletra* has one, it would be doable without making it ugly and unexpected)
Not saying it's not a good change, just that it should possibly be done on purpose :)
Fixed, thanks ;-)
b4n commented on this pull request.
@@ -1892,7 +1891,7 @@ msgstr "Mostra la _finestra dels missatges"
#: ../data/geany.glade.h:401 msgid "Show _Toolbar" -msgstr "Mos_tra la barra d'eines" +msgstr "Mostra la barra d’_eines"
hum actually if changing the "change font" mnemonic required you to change that one, it would be just as fine to change the other one. And doesn't that conflict with "Mostra els _espais en blanc"? I know mnemonic can get annoying when you get out of practical letters… Anyway, don't feel obligated to fix it all just now, but not having duplicates is always better as it allows to activate the item directly instead of only looping through the possible matches.
Merged #1432.
We should prevent double used accelerators. As the change is beside of the issue improving translation, I've merged it. But worth reviewing for next update.
github-comments@lists.geany.org