This useful for web development. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3439
-- Commit Summary --
* add less and scss file types
-- File Changes --
M data/Makefile.am (4) A data/filedefs/filetypes.less.conf (19) A data/filedefs/filetypes.scss.conf (26) M data/filetype_extensions.conf (4)
-- Patch Links --
https://github.com/geany/geany/pull/3439.patch https://github.com/geany/geany/pull/3439.diff
@Azq2 pushed 1 commit.
bff0503c7b0af21460ae21df0a06b661d8f93500 fix file naming
@techee requested changes on this pull request.
About time that LESS and SCSS are finally supported in Geany.
Apart from the several minor comments looks good to me. Would you fix those?
@@ -79,7 +79,9 @@ filetypes_dist = \
filedefs/filetypes.vhdl \ filedefs/filetypes.xml \ filedefs/filetypes.yaml \ - filedefs/filetypes.zephir + filedefs/filetypes.zephir \ + filedefs/filetypes.SCSS.conf \ + filedefs/filetypes.LESS.conf
These are sorted alphabetically in the list in the case-insensitive manner. Could you put them to the right places?
@@ -85,6 +87,6 @@ None=*;
[Groups] Programming=Arduino;Clojure;CUDA;Cython;Genie;Groovy;Kotlin;Nim;Scala;Swift; Script=Graphviz;TypeScript;Meson; -Markup= +Markup=SCSS;LESS;
Drop this line - the [Groups] section is gone now.
@@ -22,6 +22,8 @@ COBOL=*.cob;*.cpy;*.cbl;*.cobol;
CoffeeScript=*.coffee;Cakefile;*.Cakefile;*.coffee.erb;*.iced;*.iced.erb; Conf=*.conf;*.ini;config;*rc;*.cfg;*.desktop;*.properties; CSS=*.css; +SCSS=*.scss; +LESS=*.less;
Despite being related to CSS, it should be sorted alphabetically in the list.
+[indentation=CSS]
+ +[lexer_properties=CSS] +lexer.css.less.language=1 + +[settings=CSS] +lexer_filetype=CSS +tag_parser=CSS +# default extension used when saving files +extension=less + +# LESS has single-line comments in addition to CSS multi-line ones +comment_single=// + +# MIME type +mime_type=plain/text
I'd suggest dropping this one if there's no specific mime type. If I remember correctly, the mime type is used for getting the right icon of the file type and better to get the CSS icon here.
+[indentation=CSS]
+ +[lexer_properties=CSS] +lexer.css.scss.language=1 + +[settings=CSS] +lexer_filetype=CSS +tag_parser=CSS +# default extension used when saving files +extension=scss + +# SCSS has single-line comments in addition to CSS multi-line ones +comment_single=// + +# MIME type +mime_type=plain/text
Drop.
Closed #3439 via #4095.
Sorry, now I use Kate
github-comments@lists.geany.org