when executing the command select line, Geany still remembers the last X incorrectly, so `Shift-Down` and other keys don't work well. this PR sets the last X correctly for this case and many other cases. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4083
-- Commit Summary --
* fix select all to use a forward selection * set last X properly on various selection changes
-- File Changes --
M scintilla/src/Editor.cxx (7)
-- Patch Links --
https://github.com/geany/geany/pull/4083.patch https://github.com/geany/geany/pull/4083.diff
@limwz01 You will have to submit this change to the Scintilla project (through the terrible sourceforge page https://sourceforge.net/projects/scintilla/).
In Geany we use an unmodified version of Scintilla and this change would get overwritten once we update to a new Scintilla version.
well, I noticed that you don't actually use an "unmodified version of Scintilla" and do patch some stuff in `scintilla/scintilla_changes.patch` so it is actually possible to add it there. I can try getting it included in Scintilla, but... mercurial??
well, I noticed that you don't actually use an "unmodified version of Scintilla" and do patch some stuff in scintilla/scintilla_changes.patch so it is actually possible to add it there.
Yes, but the patch is only to remove languages we don't support, not to maintain our fork of Scintilla.
I can try getting it included in Scintilla, but... mercurial??
Same here :-)
But you can avoid the mercurial thing altogether. What I typically do when submitting patch to Scintilla is that I download the latest release tarball (Scintilla development isn't so active so there probably won't be conflicts with your code if it differs from the current master), create a git repository in it and add all files, then make my modifications, commit them, and finally git-format-patch the result and submit it as an attachment of the Sourceforge issue.
What I typically do when submitting patch to Scintilla is that I download the latest release tarball ...
For future reference, there are git mirrors available, e.g.,
git clone --branch default https://github.com/orbitalquark/scintilla-mirror.git
Closed #4083.
closing because my [patches to Scintilla](https://sourceforge.net/p/scintilla/feature-requests/1536/) were not welcome.
github-comments@lists.geany.org