[geany/geany-plugins] Geanymacro plugin completely crashes Geany (#585)

List overview All Threads

newer

older

Re: [Github-comments]...

[geany/geany-plugins] Pass a...

Mike Collins

21 Jun 2017 21 Jun '17

6:14 a.m.

I've tried using on 2 different PC's Both Windows, 1 10 Enterprise and the other 8.1 Pro, both 64bit.

When I select the "Macros" option in the plugin manager is when it crashes.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585

Attachments:

attachment.htm (text/html — 1.9 KB)

Show replies by date

Matthew Brush

21 Jun 21 Jun

7:15 a.m.

Confirmed on Windows 10 Pro x64 with Geany 1.30 and Windows 7 Professional SP1 x64 Geany 1.30.1.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-309965550

Frank Lanitz

8:24 a.m.

Cannot reproduce. Please provide backtrace

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-309975617

discorichardson

22 Jun 22 Jun

5:54 p.m.

I think Numbered Bookmarks crashes in the same way on windows. I think they both create a folder to store settings then crash Geany.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310423114

Matthew Brush

23 Jun 23 Jun

2:06 a.m.

Confirmed same issue with Numbered Bookmarks with same versions as above.

@discorichardson How do you know they both try and create folders before crashing? Any idea which folders? I hate debugging on Windows on release builds.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310534902

Matthew Brush

2:16 a.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

I tested loading/unloading all of the other plugins and these are the only two I found with this problem.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310536418

Enrico Tröger

6:28 a.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

I've got a stack trace which reveals it crashes somewhere in GDK, the last relevant frame in the stack is ``` #2 0x66b065ee in plugin_init () from C:\Program Files (x86)\geany\lib\geany\geanymacro.dll ``` which doesn't help much.

I just triggered a full debug build on my machine to get a better stack trace.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310568292

Enrico Tröger

7:57 a.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

``` #2 0x66b065ee in plugin_init (data=0x6a3ae8e0 <geany_data>) at geanymacro.c:2219 ``` which is ```c k=gdk_keymap_get_entries_for_keyval(NULL,'0'+i,&gdkkmkResults,&iResults); ``` I'll have a look at this at the weekend except anyone is faster.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310578992

discorichardson

10:10 a.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

It looks like you've narrowed it down enough now.

In both cases after clicking checkbox to activate the plugin a folder is successfully created, and then Geany crashes.

The empty folders (on windows 7) are: C:\Users[username]\AppData\Roaming\geany\plugins\Geany_Numbered_Bookmarks C:\Users[username]\AppData\Roaming\geany\plugins\Geany_Macros

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310601643

Matthew Brush

12:04 p.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

@eht16 Is it the same function for Numbered Bookmarks?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310626722

elextr

2:42 p.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

Just FYI, the following message occurs on enabling these plugins on Linux, so I think @eht16 is in the right area.

``` (geany:9266): Gdk-CRITICAL **: gdk_keymap_get_entries_for_keyval: assertion 'GDK_IS_KEYMAP (keymap)' failed ```

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310655337

Colomban Wendling

11:01 p.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

https://developer.gnome.org/gdk2/stable/gdk2-Keyboard-Handling.html#gdk-keym...

...

Note that passing `NULL` for `keymap` is deprecated and will stop to work in GTK+ 3.0. Use [`gdk_keymap_get_for_display()`](https://developer.gnome.org/gdk2/stable/gdk2-Keyboard-Handling.html#gdk-keym...) instead.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310771944

Enrico Tröger

24 Jun 24 Jun

12:32 p.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

@codebrainz yes, exactly the same issue with Numbered Bookmarks.

@b4n to the rescue. Thanks, that was exactly the error.

Interestingly, on Windows I don't see the warning Lex posted. But GeanyLua is also affected.

Anyway, it's easy to fix. Will do a PR.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310830695

Frank Lanitz

4:16 p.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

Closed #585 via #586.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#event-1137467965

Matthew Brush

4:18 p.m.

New subject: [geany/geany-plugins] Macros and Numbered Bookmarks plugins crash Geany (#585)

It sounds more like a GDK bug, it's weird something deprecated should cause a runtime assertion failure, and especially there's no reason it should crash the whole process. Oh well, GTK+ isn't exactly known for stability anymore :)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/585#issuecomment-310841251

2551

Age (days ago)

2554

Last active (days ago)

github-comments@lists.geany.org

14 comments

7 participants

tags (0)

participants (7)

Colomban Wendling
discorichardson
elextr
Enrico Tröger
Frank Lanitz
Matthew Brush
Mike Collins