[geany/geany] Missing PHP Keywords (#1546) - Github-comments - lists.geany.org

List overview All Threads

[geany/geany] Missing PHP Keywords (#1546)

[geany/geany] White text when...

[geany/geany] middle click paste...

klaxian

18 Jul 2017 18 Jul '17

3:34 p.m.

Many PHP keywords are missing from the definition. Some of the missing keywords are new for PHP 7.x, but others are old.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546

Attachments:

attachment.htm (text/html — 1.7 KB)

Reply

Show replies by date

klaxian

18 Jul 18 Jul

3:41 p.m.

The patch to fix this is attached: [geany_php7_keywords_patch.txt](https://github.com/geany/geany/files/1156411/geany_php7_keywords_patch.txt)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546#issuecomment-316105157

Reply

klaxian

3:42 p.m.

Patch attached: [geany_php7_keywords_patch.txt](https://github.com/geany/geany/files/1156416/geany_php7_keywords_patch.txt)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546#issuecomment-316105542

Reply

Enrico Tröger

9:33 p.m.

Would you mind to update your patch with: - sort the list alphabetically, this makes future changes easier and less error-prone - mention the source of the keywords - ideally make a pull request for your change

Thanks.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546#issuecomment-316204643

Reply

klaxian

19 Jul 19 Jul

2:33 p.m.

Closed #1546.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546#event-1170359037

Reply

klaxian

2:33 p.m.

I already sorted the list alphabetically. Did you find a mistake? I created PR #1547 for this. I will post a comment with justification as you requested.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546#issuecomment-316406897

Reply

Enrico Tröger

8:55 p.m.

Sorry about the note about sorting, I confused myself while reading the diff :(. Thanks for the PR.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1546#issuecomment-316514510

Reply

2648

Age (days ago)

2649

Last active (days ago)

github-comments@lists.geany.org

6 comments

2 participants

tags (0)

participants (2)

Enrico Tröger
klaxian