If no explicit installation directory was specified and an existing, Geany installation was found, then use its installation directory.
Closes #1321. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1324
-- Commit Summary --
* Windows installer: Prefer Geany installation directory over user's HOME
-- File Changes --
M build/geany-plugins.nsi (25)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1324.patch https://github.com/geany/geany-plugins/pull/1324.diff
@eht16 commented on this pull request.
@@ -401,6 +398,12 @@ Function .onInit
StrCpy $INSTDIR "$GEANY_INSTDIR" ${EndIf}
+ ; if $INSTDIR has not been set yet above, set it to the profile directory for non-admin users + ${If} $INSTDIR == ""
The diff is a bit cluttered because of the variable rename (I don't know what was wrong with me naming it "Answer" :( ), the relevant part is here: we set `$INSTDIR` only to the user's profile directory if we didn't find a Geany installation before. Before the Geany installation was ignored if the installer was executed without administrative privileges.
Merged #1324 into master.
github-comments@lists.geany.org