I have tested this in debian testing and ubuntu 16.04 and works for both gtk2 and gtk3. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/467
-- Commit Summary --
* Macro gtk3 compatibility [Needs testing] * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * upstream compatibility * Merge branch 'master' of github.com:sagarchalise/geany-plugins * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge branch 'master' of github.com:sagarchalise/geany-plugins * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Gtk3 support
-- File Changes --
M build/geanydoc.m4 (1) M geanydoc/src/geanydoc.c (24)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/467.patch https://github.com/geany/geany-plugins/pull/467.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/467
@@ -284,15 +284,14 @@ on_comboboxType_changed(GtkComboBox * combobox, G_GNUC_UNUSED gpointer user_data
#define GLADE_HOOKUP_OBJECT(component,widget,name) \ g_object_set_data_full (G_OBJECT (component), name, \
- gtk_widget_ref (widget), (GDestroyNotify) gtk_widget_unref)
- g_object_ref (widget), (GDestroyNotify) gtk_widget_destroy)
`gtk_widget_destroy` isn't the same as `gtk_widget_unref`, `g_object_unref` would be a lot closer. It may or may not change anything, depending on how it's used, but it probably would be "safer" to use `g_object_unref`
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/467/files/280902ad73fdee54c9df8d...
@@ -336,7 +332,9 @@ create_Configure(void) gtk_window_set_title(GTK_WINDOW(Configure), _("Doc")); gtk_window_set_type_hint(GTK_WINDOW(Configure), GDK_WINDOW_TYPE_HINT_DIALOG);
- dialog_vbox1 = GTK_DIALOG(Configure)->vbox;
- dialog_vbox1 = gtk_vbox_new(FALSE, 6);
doesn't this `6` change UI layout?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/467/files/280902ad73fdee54c9df8d...
@@ -336,7 +332,9 @@ create_Configure(void) gtk_window_set_title(GTK_WINDOW(Configure), _("Doc")); gtk_window_set_type_hint(GTK_WINDOW(Configure), GDK_WINDOW_TYPE_HINT_DIALOG);
- dialog_vbox1 = GTK_DIALOG(Configure)->vbox;
- dialog_vbox1 = gtk_vbox_new(FALSE, 6);
also, you could assume just fine that `gtk_dialog_get_content_area()` returns a VBox if you wanted
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/467/files/280902ad73fdee54c9df8d...
LGBI apart my small comments. But this might require a little checking of the actual widget packing behavior, because the GTK3 defaults are different.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/467#issuecomment-234308935
@sagarchalise pushed 1 commit.
34e015b Changes according to pr comment
--- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/467/files/280902ad73fdee54c9df8d...
The commits should be cleaned up (possible squash everything into one).
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/467#issuecomment-235680739
Merged #467.
github-comments@lists.geany.org