This is reworked version if #295
I opened a new PR because I don't have incremental commits available (I cherry picked from the upstream PR https://github.com/codebrainz/geanypy/pull/37) and didn't want to destroy the comments there.
Anyway, the commits tell the story. This PR converts geanypy to a proxy plugin (needs Geany git master/1.26), and then adds the long-awaited keybindings support.
With this, python plugins are just like other plugins w.r.t to the PM dialog, configuration and keybindings
According to #295 @codebrainz is fine if G-P merges it first (@codebrainz please speak up if you changed your mind). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/384
-- Commit Summary --
* Convert to a proxy plugin * Store per-plugin GeanyPlugin pointer * Add support for keybindings * proxy: backward compatibility for legaxy show_configure() * docs: update docs for the proxy plugin changes
-- File Changes --
M geanypy/README (11) M geanypy/doc/source/starting.rst (40) M geanypy/geany/Makefile.am (2) M geanypy/geany/__init__.py (4) D geanypy/geany/loader.py (172) D geanypy/geany/manager.py (179) M geanypy/geany/plugin.py (16) M geanypy/plugins/Makefile.am (2) M geanypy/plugins/console.py (16) M geanypy/src/Makefile.am (3) A geanypy/src/geanypy-keybindings.c (213) A geanypy/src/geanypy-keybindings.h (39) M geanypy/src/geanypy-plugin.c (383) M geanypy/src/geanypy-plugin.h (12) M geanypy/src/geanypy-signalmanager.c (1)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/384.patch https://github.com/geany/geany-plugins/pull/384.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384
@frlan @elextr ping :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-192884199
Well, I can't test it and its too big for more than a scan inspection, but it has been beaten up on upstream a bit so I'm ok with it.
BTW has it ever been tested on windows?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-194588967
@frlan can't see the official label to add so just saying ok here :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-194589354
@kugel- I have been testing this enhancement in geanypy. It doesnot load plugins in `~/.config/geany/plugins` directory. I get `ImportError`. I have been testing these plugins
https://github.com/sagarchalise/geanypy-emmet https://github.com/sagarchalise/geanypy-reStructured-preview
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-194659183
@sagarchalise it never did that. It thinkpad you have to Do it manually (for extra modules). Or are you saying your main plugins file can't be loaded?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-194887771
@frlan ping
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-195207521
Merged #384.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#event-585972765
You guys are crazy merging such a big change so close to release :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-195404616
@kugel- My main plugin file is loaded only from `/usr/local/lib/geany` path but not from config directory.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-195443375
Try latest master, I made a bug fix regarding that.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-195495020
You guys are crazy merging such a big change so close to release :)
But upstream so totally tested it :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-195596666
github-comments@lists.geany.org