Instead of hard coding a space after `make` for the default command, always put a space. If the user changes the command, it's easy for them to remove the trailing space, and the argument can then change which command is run. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3825
-- Commit Summary --
* [Make Custom Target] Always put a space between command and argument
-- File Changes --
M src/build.c (8)
-- Patch Links --
https://github.com/geany/geany/pull/3825.patch https://github.com/geany/geany/pull/3825.diff
@elextr requested changes on this pull request.
The space is currently only added to pre-0.19 formats, so adding it to all formats is an incompatible change. It assumes that the user is typing a full argument as they are required to do pre-0.19 but post 0.19 formats allow them to only have to type part of the argument.
Currently if the user configured "my_build_script f" in the GUI for custom command and typed "oo" the command is "my_build_script foo" but this change will make it "my_build_script f oo" with no way to recover.
Closed #3825.
At least with #3833 it'll be clearer what command gets run.
github-comments@lists.geany.org