This happened in the past until d35e66493c7f80768dc5b8761d62ec74434bfdae because of https://sourceforge.net/p/geany/bugs/163/ and https://bugzilla.gnome.org/show_bug.cgi?id=540161. But since the VTE bug has been fixed for long, we can remove the workaround.
Closes #352. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2116
-- Commit Summary --
* Restart the shell if VTE restart is requested
-- File Changes --
M src/vte.c (1)
-- Patch Links --
https://github.com/geany/geany/pull/2116.patch https://github.com/geany/geany/pull/2116.diff
b4n approved this pull request.
Not sure why we need to kill the child, but this works for me for correcting the issue. I would have though the `child-exited` handler should do all what is needed, but well.
FTR, I can reproduce seeing "weird behavior" of the directory following feature after restarting the terminal. I say weird because it stops working with some directories, maybe the one in which it was when it got restarted or something? I didn't investigate far enough but it looks reasonable when looking at the code.
If you find more details about the weird behaviour, let's create a new issue. I wasn't able to break it again with this change.
Ok to merge for 1.35?
If you find more details about the weird behaviour, let's create a new issue. I wasn't able to break it again with this change.
me neither, it worked fine with the fix, but I can't say I tested it for months either :)
Ok to merge for 1.35?
Yes
Merged #2116 into master.
github-comments@lists.geany.org