…dex.py as porting to Python3 would need more changes, updated ADDING-A-THEME.md to indicate the scripts/ code requires Python2 which is not indicated anywhere, added properly generated JSON indexes.
After more detailed investigation, the folowing changes (aside of the theme colors) were required, as it appears the previous commit broke the geany-themes website. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-themes/pull/59
-- Commit Summary --
* Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkindex.py as porting to Python3 would need more changes, updated ADDING-A-THEME.md to indicate the scripts/ code requires Python2 which is not indicated anywhere, added properly generated JSON indexes.
-- File Changes --
M ADDING-A-THEME.md (61) M colorschemes/evg-ega-dark.conf (10) M index/index.json (692) M index/index.json.md5 (2) M scripts/mkindex.py (2)
-- Patch Links --
https://github.com/geany/geany-themes/pull/59.patch https://github.com/geany/geany-themes/pull/59.diff
@eht16 commented on this pull request.
@@ -156,6 +156,67 @@ of the tree.
If you don't have GNU make (ex. on Windows), don't worry about doing this step, it's entirely trivial for me to do it.
+IMPORTANT NOTE 2023-05-11 by Evgueni Antonov (github: StrayFeral):
This file is meant as instructions on how to add new themes.
It's not really the right place to write about your experiences :).
Also, we should not encourage people to continue using Python2 but rather port the code to Python3.
I would say just remove the changes in this file.
@eht16 commented on this pull request.
On index/index.json:
Not necessary, master has already an updated index (see #58).
@eht16 commented on this pull request.
@@ -8,7 +8,7 @@
import os import sys import json -from configparser import ConfigParser +import ConfigParser
See #58 where the script is roughly ported to Python3 though there is still way more to do (linting, modernising the code, ...) but it works well enough to generate the index.json.
AFAICT #58 merge supercedes this, closing.
Closed #59.
github-comments@lists.geany.org