Added 3 more keybindings for "Send Selection To".
I am obviously missing something. The keybindings are recognized (i.e. I can add more "Sent Selection To" commands and the keybinding will be shown in the menus of "Edit→Format→Send Selection to") and I can run the commands by manually going to "Edit→Format→Send Selection to" and clicking the desired command. However, pressing the keyboard shortcut for these new "Edit→Format→Send Selection to" commands will not run the assigned commands. Perhaps, somebody can point me in the correct direction. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2536
-- Commit Summary --
* Added 3 More Keybindings * Added 3 More Keybindings * Added 3 More Keybindings
-- File Changes --
M src/keybindings.c (6) M src/keybindings.h (3) M src/tools.c (3)
-- Patch Links --
https://github.com/geany/geany/pull/2536.patch https://github.com/geany/geany/pull/2536.diff
[Hint](https://github.com/geany/geany/blob/d8f532b5adf41ae57b99b6ac95d336401ba15e35...)
@DevynCJohnson pushed 1 commit.
ceb568308f52a72107ac79cc429f37a14fda45be Added the essential missing piece
@elextr , awesome. Thanks! That was it.
Are there any problems with this pull-request that is preventing it from being merged?
@elextr commented on this pull request.
@@ -275,6 +275,9 @@ enum GeanyKeyBindingID
GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */ GEANY_KEYS_DOCUMENT_STRIPTRAILINGSPACES, /**< Keybinding. * @since 1.34 (API 238) */ + GEANY_KEYS_FORMAT_SENDTOCMD10, /**< Keybinding. */ + GEANY_KEYS_FORMAT_SENDTOCMD11, /**< Keybinding. */ + GEANY_KEYS_FORMAT_SENDTOCMD12, /**< Keybinding. */
You have added these at the end, good, but they are in the plugin API but you havn't increased the API number, and then you can add it to the comments like the previous line.
One comment, otherwise looks ok, but I don't have time to test it, if you can get someone who is not you to test it and post it works that would help.
Do you actually continously use more than ten commands with 'Send Selection To'? I'm wondering if this is really necessary or if maybe the "Commander" plugin (https://plugins.geany.org/commander.html) could be an alternative.
Otherwise we might end up with 20 or more keybindings for this in the end...
@DevynCJohnson pushed 1 commit.
d809938b916243d7138393fdec2544099cfd1d1f Incremented `GEANY_API_VERSION` in plugindata.h
@elextr , I incremented `GEANY_API_VERSION` as per your suggestion.
@eht16 , yes, I use that many keybindings and commands for "Send Selection To". True, I could use Commander. However, I prefer to keep often used actions very quickly and easily accessible.
github-comments@lists.geany.org