[geany/geany] Add utils_get_real_path() and use it (#1224)

List overview All Threads

newer

older

[geany/geany] Colors for selected...

[geany/geany] Re-enable SIGTERM...

Matthew Brush

11 Sep 2016 11 Sep '16

4:01 p.m.

This is a wrapper around `tm_get_real_path()` but is in a more suitable namespace/module.

I think it makes more sense like this. I typically dislike adding general-purpose functions to the API, but since Glib doesn't provide any equivalent, it really is useful. You can view, comment on, or merge this pull request online at:

https://github.com/geany/geany/pull/1224

-- Commit Summary --

* Add utils_get_real_path() and use it

-- File Changes --

M src/app.h (2) M src/document.c (8) M src/libmain.c (2) M src/plugindata.h (2) M src/tagmanager/tm_source_file.c (2) M src/utils.c (29) M src/utils.h (1)

-- Patch Links --

https://github.com/geany/geany/pull/1224.patch https://github.com/geany/geany/pull/1224.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Matthew Brush

11 Sep 11 Sep

4:09 p.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

@codebrainz pushed 1 commit.

0370112 Mark tm_get_real_path with G_DEPRECATED_FOR

-- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1224/files/d8a5212bd93843d813c6cfcfe56b7...

Matthew Brush

18 Sep 18 Sep

2:54 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

If there are no objections, I will merge this "soon".

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-247817059

elextr

3:12 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

elextr commented on this pull request.

LGBI

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#pullrequestreview-466340

Colomban Wendling

9:02 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

b4n commented on this pull request.

Otherwise, LGTM

...

@@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

-gchar *tm_get_real_path(const gchar *file_name); +gchar *tm_get_real_path(const gchar *file_name) +#ifndef GEANY_PRIVATE +G_DEPRECATED_FOR(utils_get_real_path) +#endif

Meh, can't we move the implementation at the non-deprecated place and use it in the deprecated one, instead of this?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#pullrequestreview-469697

Matthew Brush

11:11 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

codebrainz commented on this pull request.

...

@@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

-gchar *tm_get_real_path(const gchar *file_name); +gchar *tm_get_real_path(const gchar *file_name) +#ifndef GEANY_PRIVATE +G_DEPRECATED_FOR(utils_get_real_path) +#endif

You mean a reverse dependency of TagManager on Geany?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224

Colomban Wendling

11:29 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

b4n commented on this pull request.

...

@@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

-gchar *tm_get_real_path(const gchar *file_name); +gchar *tm_get_real_path(const gchar *file_name) +#ifndef GEANY_PRIVATE +G_DEPRECATED_FOR(utils_get_real_path) +#endif

Yeah; now it's under *src/* it might not be so bad

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224

Matthew Brush

11:31 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

codebrainz commented on this pull request.

...

@@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

-gchar *tm_get_real_path(const gchar *file_name); +gchar *tm_get_real_path(const gchar *file_name) +#ifndef GEANY_PRIVATE +G_DEPRECATED_FOR(utils_get_real_path) +#endif

It seems wrong, which is why I did it like this, but if you'd prefer to have TM also depend on Geany, I can change it to be so.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224

Colomban Wendling

12:59 p.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

b4n commented on this pull request.

...

@@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

-gchar *tm_get_real_path(const gchar *file_name); +gchar *tm_get_real_path(const gchar *file_name) +#ifndef GEANY_PRIVATE +G_DEPRECATED_FOR(utils_get_real_path) +#endif

Myeah it wouldn't really be pretty either. I don't care much, you can keep it like it's now.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224

Jiří Techet

12 Oct 12 Oct

12:49 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

techee commented on this pull request.

...

@@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

-gchar *tm_get_real_path(const gchar *file_name); +gchar *tm_get_real_path(const gchar *file_name) +#ifndef GEANY_PRIVATE +G_DEPRECATED_FOR(utils_get_real_path) +#endif

We might need TM to depend on Geany anyway - while working on https://github.com/geany/geany/pull/963 I realized I'd need to know in TM if GIO is used for opening/saving files or not.

We actually don't need to create the libtagmanager library - the sources inside "tagmanager" can just be other sources of libgeany.

Otherwise +1 for moving this function outside of TM - it doesn't belong there and I wanted to do this myself (but like Colomban I'd prefer having the implementation in utils).

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224

Colomban Wendling

30 Oct 30 Oct

11:52 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

Okay if you want, we can always move the implementation later.

The API version should be fixed, because it won't merge cleanly as is (no idea why GitHub doesn't complain BTW).

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-257144137

elextr

23 Feb 23 Feb

3:04 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

Moved to 1.31

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-281868370

Jiří Techet

10:07 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

Would be nice to stop incrementing the target release get this finally merged in 1.31. I believe the only thing that @b4n requested was updating the API in the docstring which should now be 1.31. @codebrainz could you make this change?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-281935610

elextr

10:24 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

@techee it would be nice to get it done, but since its now only just over a week to release IMHO no more changes other than bugfixes should be included.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-281939660

Jiří Techet

11:09 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

@elextr As I said, for 1.31, not 1.30.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-281950577

elextr

11:16 a.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

Sorry @techee I misread :)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-281952301

Thomas Martitz

24 Jul 24 Jul

11:27 p.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

What about this?

(On a related note, our `realpath()` implementation for win32, called by `tm_get_real_path()` is buggy, see #1534)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-317560311

Enrico Tröger

30 Jul 30 Jul

4:35 p.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

I'm fine with this. However, I would support the idea of moving the implementation into `src/utils.c` as it is where it should live after any deprecation.

And of course, updating Geany and API version.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-318905784

Matthew Brush

4 Aug 4 Aug

12:51 p.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

Closed in 4a60cdd12727f8f252a3e0d6921e26377ef84904

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#issuecomment-320219614

Matthew Brush

12:51 p.m.

New subject: [geany/geany] Add utils_get_real_path() and use it (#1224)

Closed #1224.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1224#event-1192947093

2697

Age (days ago)

3024

Last active (days ago)

github-comments@lists.geany.org

19 comments

6 participants

tags (0)

participants (6)

Colomban Wendling
elextr
Enrico Tröger
Jiří Techet
Matthew Brush
Thomas Martitz