@konsolebox pushed 1 commit.

cb78868 Say displaying, not printing

--- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1132/files/658cf3758b0ec782b7898c8d3762c...

Closed #1132.

@eht16 I'm no longer interested in trying to push any of my patches to Geany since I'm not interested in altering any of them to suit the author's liking, but feel free to merge any them. Also the improvements I made to the save functions which recently were closed have to be merged before I reconsider contributing again. They are necessary fixes for consistent runtime and I don't compromise.

I have made plenty of changes to Geany in 2016 and I summarized it in this [post](https://konsolebox.io/blog/2016/12/03/a-set-of-patches-for-geany.html). Feel free to look at them and use any of them you might find usable. I've been using this enhanced 1.29 version for 5 years and I never really felt upgrading since.

...

I'm not interested in altering any of them to suit the author's liking

Since the "authors" you seem to be referring to are the Geany devs who volunteer their time to be responsible for maintaining and developing Geany their "liking" is what keeps Geany a reasonably consistent application.

All is fair since I too have my own views on how an application should be done consistently, and I don't have the patience to keep updating the code for ridiculous nitpick reasons which hugely underweigh the benefits and current issues that could be fixed. Anyhow I no longer have the interest in trying to compromise with anything or working with the patches in general. It's been 5 years and nothing happened. I already did enough compromising effort back then and not even one of my PRs got merged including simple uncompromising ones like this.

...

Also the improvements I made to the save functions which recently were closed have to be merged before I reconsider contributing again.

That is of course your choice, but AFAICT from the several PRs on the topic the result was #1194 which I closed because it was a 2016 PR with no comments or pings and that had merge conflicts. This usually indicates its no longer relevant or the OP no longer wanted/needed it. I noted on the close that if it was still wanted and the conflicts were fixed it could be re-opened, and IIUC you can do that as OP.

Pings wouldn't have helped. It was simply a matter of whether the solution was wanted or not, and after 5 years surely it means it wasn't. I provided all the responses and changes needed there (both in #1194 and #1180). I did see the note, but I see no point for me to update the code again. It came to have merge conflicts because it was unwanted.

Of your other PRs, #662 was superceded by ctags upstream changes,

Yes I acknowledged this.

and #1144 was a large intrustive change that could be done by a plugin, and indeed a prototype plugin was provided, which you could have taken and supported instead of demanding the person who kindly provided it did that for you.

I failed on making the plugin and finally gave up for plenty of reasons. One of those is none of my PRs were getting acknowledged which was disheartening, and trying to push the plugin to work is another plenty of work when it's more practical to just merge it to the core. I think I decided to keep the core version solution for myself and still create the plugin but after seeing none of my other PRs were getting acknowledged I lost enthusiasm. I think I also saw that some changes would be needed in the core's plugin system for the plugin to work which if I am correct has something to do with the tabs, not sure, but anyway I didn't like collaborating for it. The sample plugin by the way if I recall correctly was nothing similar to the solution I made so it was nothing more than a plugin example.

Anyway I'm done working with the patches. I still plan on hacking Geany from time to time but this time I'm completely abandoning compatibility and possibility to rebase to newer versions.