This fixes the discrepancy where `configure --help` shows "default=no" but the api-docs are built anyway (fixes #2189) You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2190
-- Commit Summary --
* geany-doxygen.m4:don't generate doxygen by default
-- File Changes --
M m4/geany-doxygen.m4 (2)
-- Patch Links --
https://github.com/geany/geany/pull/2190.patch https://github.com/geany/geany/pull/2190.diff
I think this is intentional; if you have the needed dependencies, the docs will be built, otherwise they won't. If you use `--enable-*` and don't have the dependencies, it will fail with an error saying as much.
codebrainz commented on this pull request.
@@ -7,7 +7,7 @@ AC_DEFUN([GEANY_CHECK_DOXYGEN],
[AS_HELP_STRING([--enable-api-docs], [generate API documentation using Doxygen [default=no]])], [geany_with_doxygen="$enableval"], - [geany_with_doxygen="auto"]) + [geany_with_doxygen="no"])
I think the bug is a couple lines up where it says `[default=no]`, it should probably say `[default=auto]`.
elextr commented on this pull request.
@@ -7,7 +7,7 @@ AC_DEFUN([GEANY_CHECK_DOXYGEN],
[AS_HELP_STRING([--enable-api-docs], [generate API documentation using Doxygen [default=no]])], [geany_with_doxygen="$enableval"], - [geany_with_doxygen="auto"]) + [geany_with_doxygen="no"])
Yes, auto should be the default.
@andy5995 pushed 1 commit.
bd2fbc8ced93380747c45435949c909ca7a12791 show the default as "auto" (#2189)
andy5995 commented on this pull request.
@@ -7,7 +7,7 @@ AC_DEFUN([GEANY_CHECK_DOXYGEN],
[AS_HELP_STRING([--enable-api-docs], [generate API documentation using Doxygen [default=no]])], [geany_with_doxygen="$enableval"], - [geany_with_doxygen="auto"]) + [geany_with_doxygen="no"])
fixed
b4n approved this pull request.
LGTM, but commits should be squashed with a more accurate commit message fitting the new change
kugel- approved this pull request.
Sorry that I edited the title and first comment, I mistakingly thought it would be necessary for squash-merging but github actually let's me provide the commit message.
Merged #2190 into master.
github-comments@lists.geany.org