Imlements a new feature which allows to remove every n-th line. The user can enter the value of 'n' in a dialog. Implements #772. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/860
-- Commit Summary --
* lineoperations: remove every n-th line
-- File Changes --
M lineoperations/src/linefunctions.c (42) M lineoperations/src/linefunctions.h (5) M lineoperations/src/lineoperations.c (4)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/860.patch https://github.com/geany/geany-plugins/pull/860.diff
@LarsGit223 pushed 1 commit.
3d50545c5dd97b26f0f1aa27837f4537eaf711a2 lineoperations: adjusted menu
**Don't merge yet!** There is an error: need to add lineoperations to POTFILES.in. Will do that tomorrow.
Done. Updated POTFILES.in and also completed the README.
@smostertdev should take over review maybe
@frlan: we have nearly waited 2 month for a reply. I vote for merging this. It's quite a simple change and my tests looked good. Of course you can test it yourself if you like.
@smostertdev is the lineoperations maintainer I think.
@elextr: yeah, but he didn't reply so I contacted frlan as he seems to be kind of the manager of geany-plugins.
I cannot do anything about how people responses. However, I did not found anything cruzial while reading over code. Let's test it in practice.
Merged #860 into master.
@frlan: of course you can't. Please don't get me wrong: I did not mean to criticise you or smostertdev. It's just that it is a simple change and I think it's better to merge it at some point than to keep it open for several months. If it was a larger PR - yeah then we definitely would need to wait.
@LarsGit223 my comment was actually just meant to be a "subtle"??? re-ping :)
Glad to see that everyone is more on top of things than me. I just double checked it, compiled it and tested it and it looks great. Don't see any issues with to code, well written @LarsGit223
github-comments@lists.geany.org