Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new Scintilla API.
Is this OK? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1277
-- Commit Summary --
* Add missing style mappings for new and updated Scintilla lexers * Require Geany 2.0 as minimum version
-- File Changes --
M configure.ac (2) M spellcheck/src/scplugin.c (2) M spellcheck/src/speller.c (118)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1277.patch https://github.com/geany/geany-plugins/pull/1277.diff
Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new Scintilla API.
Is this OK?
It is, especially as I just merged #1281 which also uses newer API :smile:
Yesterday I noticed that the GeanyLua plugin also uses Scintilla 5.x API and so the version requirement bump is more than justified I think. Adding conditionals in mutiple plugins only for a hypothetical backwards compability seems not very reasonable.
Merged #1277 into master.
github-comments@lists.geany.org