This is a mirror of https://github.com/codebrainz/geanypy/pull/37. @codebrainz said he's fine if this gets merged into G-P first.
Anyway, the commits tell the story. This PR converts geanypy to a proxy plugin (needs Geany git master/1.26), and then adds the long-awaited keybindings support.
With this, python plugins are just like other plugins w.r.t to the PM dialog, configuration and keybindings You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/295
-- Commit Summary --
* geanypy: Fix build on some systems * geanypy: convert to a proxy plugin * geanypy: new type geany.PluginBase * geanypy: add support for keybindings.
-- File Changes --
M geanypy/geany/Makefile.am (2) M geanypy/geany/__init__.py (2) D geanypy/geany/loader.py (172) D geanypy/geany/manager.py (179) M geanypy/geany/plugin.py (9) M geanypy/plugins/Makefile.am (2) M geanypy/plugins/console.py (16) M geanypy/src/Makefile.am (4) M geanypy/src/geanypy-plugin.c (506) M geanypy/src/geanypy-plugin.h (10) M geanypy/src/geanypy-signalmanager.c (1)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/295.patch https://github.com/geany/geany-plugins/pull/295.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295
I do want this merged for 1.26, I hope we can manage it.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154572260
You should ping [the maintainer](https://github.com/geany/geany-plugins/blob/master/MAINTAINERS#L141) :)
I can't remember if I asked this yet, but does it break people's existing plugins?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154582160
Folks, we do have string freeze and release is next week. Unless there are real good reasons I think we shouldn't merge it for 1.26.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154594206
@frlan this doesn't introducenew strings, and we're not formally feature frozen yet. On the other hand this are real improvements to geanypy, especially keybindings have been long asked for. It also fixed the other bug where geanypy would be disabled while python plugins are loaded.
@codebrainz all existing plugins continue to work. The only thing is that their configure implementation needs to be updated, and until then you cannot configure them. But they can read their existing configuration and still function as before
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154654048
This merge will break current Python plugins in some way with a very low time in response. It changes basic things inside geanypy and is depending on a fresh introduced binding in Geany core. I know you might dislike this decision, but due to this I will add this PR to 1.27 and will not merge it for 1.26.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154753235
@codebrainz all existing plugins continue to work. [...]
I just tested the PR against upstream and my simple plugin wasn't available after the PR. I'd say that doesn't qualify as "continue to work" :) I wonder if the GeanyPy loader could somehow locate and adapt old scripts to continue to work (even without `configure()`)?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154768791
Am 8. November 2015 02:12:47 MEZ, schrieb Matthew Brush notifications@github.com:
@codebrainz all existing plugins continue to work. [...]
I just tested the PR against upstream and my simple plugin wasn't available after the PR. I'd say that doesn't qualify as "continue to work" :) I wonder if the GeanyPy loader could somehow locate and adapt old scripts to continue to work (even without `configure()`)?
Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154768791
That's unexpected. Can you paste the plug-in somewhere?
I tested against the shipped ones and one of a irc user.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154779982
@kugel- http://pastebin.geany.org/vvr42/
I just took the Hello World one and renamed it a bit. It's file is at `$HOME/.config/geany/plugins/geanypy/plugins`.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154780187
Am 8. November 2015 08:00:45 MEZ, schrieb Matthew Brush notifications@github.com:
@kugel- http://pastebin.geany.org/vvr42/
I just took the Hello World one and renamed it a bit. It's file is at `$HOME/.config/geany/plugins/geanypy/plugins`.
Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154780187
Ah, I forgot thatched plugins have to be placed directly under $HOME/.config/geany/plugins/now, since they are loaded by geany now
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154780888
I agree that disqualifies "continue to work"
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154780904
Though it's a better place for "thatched" plugins, in the long run :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-154780999
Should be closed with merging in of #384
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#issuecomment-195928484
Closed #295.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/295#event-587747296
github-comments@lists.geany.org