When using --recursive on Windows, grep shows warnings like "recursive directory loop" due to failing inode checks. Since the Mingw runtime doesn't support inodes, the patch will disable inode checking in grep and so grep can work properly on Windows. Patch is taken from http://mingw-users.1079350.n2.nabble.com/Building-GREP-td7582694.html.
Closes #1229.
The patch file is currently still located at http://download.geany.org/snapshots/grep-2.25-win64_sameinode.patch. I will move the file to the correct location once this PR is going to be merged. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1237
-- Commit Summary --
* Add patch for self-compiled grep to fix recursive searching
-- File Changes --
M scripts/gtk-bundle-from-msys2.sh (12)
-- Patch Links --
https://github.com/geany/geany/pull/1237.patch https://github.com/geany/geany/pull/1237.diff
b4n requested changes on this pull request.
changes LGBI
tar xf ${grep_archive}
+ # patch grep sources to fix "recursive directory loop warnings" and recusrive search, see #1229
full URL for the bug would be nice
eht16 commented on this pull request.
tar xf ${grep_archive}
+ # patch grep sources to fix "recursive directory loop warnings" and recusrive search, see #1229
Done
b4n approved this pull request.
The currently better solution seems to use a native 'grep' binary from the MSYS2 distribution. See #1301 for details which supersedes this change.
Closed #1237.
github-comments@lists.geany.org