You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3353
-- Commit Summary --
* Document generating ctags tests using the pretty-printing script
-- File Changes --
M HACKING (10)
-- Patch Links --
https://github.com/geany/geany/pull/3353.patch https://github.com/geany/geany/pull/3353.diff
@elextr commented on this pull request.
@@ -699,9 +699,13 @@ It can be either long or short, depending on what it tests.
The expected output should be in the file ``tests/ctags/mytest.ext.tags`` (which is the same name as the source, but with ``.tags`` appended), and -should be in the format generated by ``geany -g``. This file contains -the tag information expected to be generated from the corresponding -source file. +should be in the format generated by:: + + $ geany -g tmp.ext.tags tests/ctags/mytest.ext + $ cat tmp.ext.tags | scripts/print-tags.py > tests/ctags/mytest.ext.tags + +This file contains the tag information expected to be generated from +the corresponding source file together with its human-redable form.
"readable" not "redable" otherwise fine
@techee pushed 1 commit.
2f716ffaf28f8f8a83822bc50dbe233f41123d4b Document generating ctags tests using the pretty-printing script
@techee commented on this pull request.
@@ -699,9 +699,13 @@ It can be either long or short, depending on what it tests.
The expected output should be in the file ``tests/ctags/mytest.ext.tags`` (which is the same name as the source, but with ``.tags`` appended), and -should be in the format generated by ``geany -g``. This file contains -the tag information expected to be generated from the corresponding -source file. +should be in the format generated by:: + + $ geany -g tmp.ext.tags tests/ctags/mytest.ext + $ cat tmp.ext.tags | scripts/print-tags.py > tests/ctags/mytest.ext.tags + +This file contains the tag information expected to be generated from +the corresponding source file together with its human-redable form.
Yeah, thanks, fixed.
Will give this PR one week in case there are some comments before merging it.
@b4n approved this pull request.
LGTM otherwise
@@ -699,9 +699,13 @@ It can be either long or short, depending on what it tests.
The expected output should be in the file ``tests/ctags/mytest.ext.tags`` (which is the same name as the source, but with ``.tags`` appended), and -should be in the format generated by ``geany -g``. This file contains -the tag information expected to be generated from the corresponding -source file. +should be in the format generated by:: + + $ geany -g tmp.ext.tags tests/ctags/mytest.ext + $ cat tmp.ext.tags | scripts/print-tags.py > tests/ctags/mytest.ext.tags
nitpick: could use `scripts/print-tags.py < tmp.ext.tags > tests/ctags/mytest.ext.tags` and drop the :cat:
@techee pushed 1 commit.
770a0db552663912a8887d7d5f392c89cefce66c Document generating ctags tests using the pretty-printing script
@techee commented on this pull request.
@@ -699,9 +699,13 @@ It can be either long or short, depending on what it tests.
The expected output should be in the file ``tests/ctags/mytest.ext.tags`` (which is the same name as the source, but with ``.tags`` appended), and -should be in the format generated by ``geany -g``. This file contains -the tag information expected to be generated from the corresponding -source file. +should be in the format generated by:: + + $ geany -g tmp.ext.tags tests/ctags/mytest.ext + $ cat tmp.ext.tags | scripts/print-tags.py > tests/ctags/mytest.ext.tags
Right. Despite the fact that 🐈s are great, this one can be dropped. I'll merge the 🐱less version.
Merged #3353 into master.
github-comments@lists.geany.org