Integrate @elextr ['s explanation](https://github.com/geany/geany/issues/1475#issuecomment-296629551) of ABI/API into the `HACKING` document. Resolves #1475. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3027
-- Commit Summary --
* Expand ABI/API explanation in HACKING
-- File Changes --
M HACKING (18) A po/.intltool-merge-cache.lock (0)
-- Patch Links --
https://github.com/geany/geany/pull/3027.patch https://github.com/geany/geany/pull/3027.diff
@xiota pushed 1 commit.
e7554c86044fe8dfa9fd572273220d30dde336f0 remove po/.intltool-merge-cache.lock
LGTM.
@elextr commented on this pull request.
If you're reordering or changing existing elements of structs that are used as part of the plugin API, you must increment GEANY_ABI_VERSION in plugindata.h. This is usually not needed if you're just appending fields to structs. The GEANY_API_VERSION value should be incremented for any changes to the plugin API, including appending elements.
-If you're in any doubt when making changes to plugin API code, just ask us. +If you're in doubt when making changes to plugin API code, just ask us.
Not sure why you took the "any" out?
Other than the query LGTM.
@xiota commented on this pull request.
If you're reordering or changing existing elements of structs that are used as part of the plugin API, you must increment GEANY_ABI_VERSION in plugindata.h. This is usually not needed if you're just appending fields to structs. The GEANY_API_VERSION value should be incremented for any changes to the plugin API, including appending elements.
-If you're in any doubt when making changes to plugin API code, just ask us. +If you're in doubt when making changes to plugin API code, just ask us.
Took it out for line length. Any is implied. Can put it back if you want.
@elextr commented on this pull request.
If you're reordering or changing existing elements of structs that are used as part of the plugin API, you must increment GEANY_ABI_VERSION in plugindata.h. This is usually not needed if you're just appending fields to structs. The GEANY_API_VERSION value should be incremented for any changes to the plugin API, including appending elements.
-If you're in any doubt when making changes to plugin API code, just ask us. +If you're in doubt when making changes to plugin API code, just ask us.
The "any" just adds emphasis, we prefer people ask than break the API, so prefer it stays.
@xiota pushed 1 commit.
8d267aaddc41b1525057331a3d7d8552b0b37692 Restore the word "any"
@xiota commented on this pull request.
If you're reordering or changing existing elements of structs that are used as part of the plugin API, you must increment GEANY_ABI_VERSION in plugindata.h. This is usually not needed if you're just appending fields to structs. The GEANY_API_VERSION value should be incremented for any changes to the plugin API, including appending elements.
-If you're in any doubt when making changes to plugin API code, just ask us. +If you're in doubt when making changes to plugin API code, just ask us.
okay.
Merged #3027 into master.
github-comments@lists.geany.org