Grepping the source code shows this is already done in pohelper/src/gph-plugin.c at line 903.
Tests run: Compiles on GCC 14
Fixes #1297 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1298
-- Commit Summary --
* projectorganizer: prjorg-sidebar.c: Cast g_ptr_array_free to gchar**
-- File Changes --
M projectorganizer/src/prjorg-sidebar.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1298.patch https://github.com/geany/geany-plugins/pull/1298.diff
Sigh C!!! [exasperated tone] Surely it can trace the type of the pointers that were put in the array as `gchar*` where they were implicitly converted to `void*` and so allow the therefore legal implicit conversion from `void*` to `gchar*` in the return :stuck_out_tongue_winking_eye:
Anyway LGBI since I don't have gcc 14. @b4n will probably want to add this in his --b4n_pedantic :grin:
Heh they're slowly making GCC more strict it seems :) in 14 they're also no longer including `<algorithm>` by default so it's fun having to add a single line import to projects
The `<algorithm>` thing (which is C++ not C) is within the C++ standard that allows any header to include any other header (or not, which is what they changed, some headers that used to use it no longer do). Users should always include what they use irrespective of "automagic" inclusions in headers since they can change at any time. There is a [tool](https://github.com/include-what-you-use/include-what-you-use) released by Google that leeches off clang to check for it.
Closed #1298.
Ah, OK, I noticed this PR only after merging https://github.com/geany/geany-plugins/pull/1315 which eliminates some more warnings including this one.
So I'm closing this and https://github.com/geany/geany-plugins/issues/1297.
github-comments@lists.geany.org