Replace filetype_id with GeanyFiletypeID and deprecate the macro. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/931
-- Commit Summary --
* Replace filetype_id with GeanyFiletypeID * Deprecate filetype_id
-- File Changes --
M src/filetypes.c (6) M src/filetypes.h (2) M src/symbols.c (8)
-- Patch Links --
https://github.com/geany/geany/pull/931.patch https://github.com/geany/geany/pull/931.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931
I know it's not from this PR, but I wonder why use a macro instead of a typedef for compatibility?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#issuecomment-192326217
I know it's not from this PR, but I wonder why use a macro instead of a typedef for compatibility?
I don't see a reason, and if it was a typedef we could mark it with `GEANY_DEPRECATED_FOR(GeanyFiletypeID)`. We probably should change this right now before a release and people starting to throw in `#ifdef filetype_id` -- no, I doubt anybody would do that, but still.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#issuecomment-192415330
@techee I re-did virtually the same in #932. For some reason this branch has merge conflicts and it was so easy replacing the occurrences (and checking them on the way) I didn't even try using your patch. If you'd like credit, I can fix that.
That other PR replaces the macro with a typedef, too, and marks it deprecated.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#issuecomment-192509333
Oh, conflicts arose from the `TMParserType` change apparently.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#issuecomment-192512859
I seem to remember there were quite a few places where `gint` was used for filetype ID, should we fix those now too?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#issuecomment-192539841
Deprecated by https://github.com/geany/geany/pull/932. Closing.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#issuecomment-192620594
Closed #931.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/931#event-578757473
github-comments@lists.geany.org