I'm trying to customize an existing theme but am finding that the `marker_mark` colors are not being used (completely). For example, if I try to set `marker_mark=#000;#FFCC00`, I would expect black on bright yellow text. Instead I'm seeing the original foreground color of the marked text with the background color being a dark yellow.
I've even tried to change the `marker_transparency` settings but that didn't seem to make any difference at all.
I am using geany v1.26 on Linux.
Any ideas as to what I'm doing wrong?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916
`marker_mark` is used for colors of the markers in the marker margin, not in the text. What you see is probably the `marker_search`, for which only the background is used. See http://www.geany.org/manual/#id4 and the values there.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188535248
I've actually tried changing that value as well, the background color is still a dark yellow.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188535391
Ok, so we'll need to know what marker it really is (how was it created) and maybe what theme you're trying to modify.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188535860
Just to check, you did re-load the colour scheme? Geany won't do that automatically AFAIK
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188537386
I copied the Darcula theme, changed some of the theme_info to differentiate it from Darcula, and simply changed the existing `marker_search` to `marker_search=;#ffff00`.
I've also noticed if I try to use any normally bright color (for example `#00ff00`), it's just a dark version of the color, even though the brightness is correct for other syntax highlighting options (e.g. when matching a good bracket).
@elextr Yes I am doing that. I load the theme selector and click back and forth to reload. I have also tried restarting Geany.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188537601
Search marking:
1. only changes the background, so as @b4n said the foreground setting is ignored, this is the way Scintilla (the editing component we use) works, it means you can still see syntax styling on the marked text
2. is applied with a fixed alpha of 60, so you will never get your bright colours
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188550087
Is it possible to make the alpha level configurable?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188551391
Sure, just "somebody" has to do it.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188551748
@mscdex maybe add third field to [`translucency`](https://github.com/geany/geany/blob/master/data/filetypes.common#L29)? Just copy the way the existing two work and make the 3rd field get passed [here](https://github.com/geany/geany/blob/master/src/highlighting.c#L658) instead of 60, I think.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188560547
@codebrainz yeah or [here](https://github.com/geany/geany/blob/master/data/filetypes.common#L42) to continue the confusion between "markers" and "marks" :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188567569
FWIW I just tried changing the hardcoded value of 60 to any other value (including 255 for no transparency) and it didn't make any difference at all.
Just to be clear, I'm testing with the mark you get when you highlight a token/word and press ctrl+shift+m to highlight all instances of that token/word.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188568406
Hrmm... I must not be doing something right.... I even hardcoded the `SCI_INDICSETFORE` value and it still uses the color defined in my theme.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188571511
Maybe post a gist with a diff of what you changed
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188588694
@elextr gist: https://gist.github.com/mscdex/35ccffa0e10beb93fbd8
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188590418
Hmmm, well, assuming it `configure`, `make` and `make install`ed correctly and you are running the modified version (yeah I've run the wrong one :) it should do what the hard coding says AFAICT.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188596606
Yep it is the right one. The system copy is in `/usr/bin` and the one I'm testing is in `/usr/local/bin`. If someone wouldn't mind testing the same change when they get some time I would appreciate it. That way I can know if it's just me or what.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188597843
I'm afraid it appears to be just you :(
Works for me :)
Don't know what you are doing different, my recipe:
``` mkdir /path/xxx; cd /path/xxx; git clone https://github.com/geany/geany.git; cd geany ./autogen.sh --prefix=/path/xxx; make install; cd ../bin; ./geany -c ../config ```
That doesn't touch any system dirs (note no sudo needed :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188667167
The system copy is in /usr/bin and the one I'm testing is installed to /usr/local/bin.
The geany executable is just a miniscule thing that links to libgeany, so my first guess is you might be getting the wrong libgeany, IIUC the dynamic loader looks in some system dirs like `/usr/lib` and `/usr/local/lib` specially so that might be confusing it.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188673276
The Gist WFM just fine, *but* note that any value outside the 0-255 (included) range will be ignored, plain and simple. Opened PR #917 fixing the documentation and adding a setting for the search marker translucencies.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188944729
@elextr I wasn't aware of that, I will look at it again.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/916#issuecomment-188963509
github-comments@lists.geany.org