• {

• GError *error = NULL;
  

• background_image_pixbuf = gdk_pixbuf_new_from_file(path, &error);
  

• if (! background_image_pixbuf)
  

• {
  

• 	g_warning("Failed to load VTE background image: %s", error->message);
  

• 	g_error_free(error);
  

• }
  

• /* alter the background color to add alpha to it */
  

• else if (vf->vte_terminal_set_color_background_rgba)
  

• {
  

• 	GdkRGBA bg;
  

• 	/* default VTE "saturation" value is 0.4: 1.0 - 0.4 = 0.6 */
  

• 	rgba_from_color(&bg, &vc->colour_back, 0.6);
  

apparently this is wrong, and VTE doesn't use the background color to perform the blend, but black instead.

IMO the implementation here is better as it's more flexible at very little cost, but if we want to get exact same behavior we should use `GdkRGBA bg = { 0, 0, 0, 0.6 }`.

+static void default_vte_terminal_set_background_image_file(VteTerminal *terminal, const char *path) +{

• if (background_image_pixbuf)
• {

• g_object_unref(background_image_pixbuf);
  

• background_image_pixbuf = NULL;
  

• }
• if (path != NULL)
• {

• GError *error = NULL;
  

• background_image_pixbuf = gdk_pixbuf_new_from_file(path, &error);
  

• if (! background_image_pixbuf)
  

• {
  

• 	g_warning("Failed to load VTE background image: %s", error->message);
  

BTW, apparently VTE's implementation of this fails silently when the file can't be open/isn't an image. Warning is better for us I suppose, though.

Looks like a good idea to revive this pull request (especially when https://github.com/geany/geany/pull/1182 gets merged which looks like a good idea to me too) as e.g. Ubuntu 16.04 has only vte 2.91 for GTK3.

I'd personally drop the background image feature completely - it's just silly. It's similarly stupid like if we wanted to add a background image to the Scintilla editor.

People for some reason seem to configure their terminals in a very non-ergonomic ways by e.g. adding transparency to the window so the text in the terminal overlaps with whatever other text is behind the window. Nobody would do anything like that with any other application.

I'd definitively not include any custom background image implementation. For VTE versions that support it natively, and we already have UI prefs for, it seems OK to leave it, but for newer VTEs it seems better to just guard it out.

IMO it would be worth dropping completely everywhere to reduce the amount of ifdef checks. There will be half of them if this gets removed and this mis-feature isn't worth cluttering the code.

I don't know if half of them is correct, but I agree.

Its about one half of the newly-introduced ones (5 out of 11 are related to the background image).

@techee that sounds like a plan. The only stuff that needs two lots of support is the RGBA stuff IIUC, otherwise we cut off all old or all new versions.

@techee ok, I havn't examined the API in detail, but yeah sure changes like that, which are needed to actually make it work, need to be handled too. But your point is for this PR to support the common functionality across versions. Anything thats new or was removed should be dropped at this stage.

If there are fancy new features in new versions that people want to use that can be separate PRs later and simulating functionality from old versions thats missing can also be added later.

Lets keep it simple for now.

@b4n IIUC now ctrl+space or super+space is the default binding to select an input method for the desktop. Assuming your dekstop is set up with multiple input methods and languages and ibus or another one of the methods supported by your desktop is running the keybinding should get you the input method menu for any widget. Not sure if Geany keybindings would steal those bindings from VTE though?

@elextr no idea, and I probably don't have many input method configured. Or maybe I do, I have absolutely no idea actually.

Anyway, I tried to make us respect the GTK settings in 90cc03a58d7a084929ad34a9d98adf344b136352 when we have VTE API for it (and I guess it's all fine because VTE 2.91 might depend on GTK >= 3.10). It's not so hard and should be the Right Thing™.

@b4n OK, makes sense.

I didn't review this yet, but I think it's important that it's in the next release in any case.

@codebrainz please test on master ;)