Some Gtk themes define a dark foreground color for selected text, so when we set the background to dark red, it becomes difficult to read. We must therefore set a foreground color that will remain legible against our background.
Fixes #2332 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2333
-- Commit Summary --
* Define text color when setting dark background
-- File Changes --
M data/geany.css (1) M data/geany.gtkrc (1)
-- Patch Links --
https://github.com/geany/geany/pull/2333.patch https://github.com/geany/geany/pull/2333.diff
b4n approved this pull request.
LGTM. Indeed, we didn't handle the case where the theme would set a specific foreground color for the selected text, separate from the one for unselected text. I don't have such a theme, but the changes here look sensible to me, and should be harmless otherwise (but if someone changed the colors and now has to override this as well, but that's something I think we can live with).
Merged #2333 into master.
github-comments@lists.geany.org