Closes #971, closes #1947. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2045
-- Commit Summary --
* Update Scintilla to version 3.10.2
-- File Changes --
M scintilla/gtk/ScintillaGTK.cxx (7) M scintilla/gtk/ScintillaGTKAccessible.cxx (2) M scintilla/include/Platform.h (5) M scintilla/include/SciLexer.h (48) M scintilla/include/Scintilla.h (14) M scintilla/include/Scintilla.iface (90) M scintilla/lexers/LexBash.cxx (279) M scintilla/lexers/LexCPP.cxx (56) M scintilla/lexers/LexFortran.cxx (8) M scintilla/lexers/LexMarkdown.cxx (60) M scintilla/lexers/LexVerilog.cxx (6) M scintilla/lexlib/CharacterCategory.cxx (240) M scintilla/lexlib/PropSetSimple.cxx (2) M scintilla/scintilla_changes.patch (5) M scintilla/src/CaseConvert.cxx (16) M scintilla/src/Catalogue.cxx (4) M scintilla/src/CellBuffer.cxx (349) M scintilla/src/CellBuffer.h (10) M scintilla/src/ContractionState.cxx (2) M scintilla/src/Document.cxx (102) M scintilla/src/Document.h (27) M scintilla/src/EditModel.cxx (2) M scintilla/src/EditView.cxx (2) M scintilla/src/Editor.cxx (106) M scintilla/src/Editor.h (2) M scintilla/src/ExternalLexer.cxx (4) M scintilla/src/Indicator.cxx (7) M scintilla/src/KeyMap.cxx (4) M scintilla/src/KeyMap.h (1) M scintilla/src/PerLine.cxx (4) M scintilla/src/PositionCache.cxx (7) M scintilla/src/PositionCache.h (2) M scintilla/src/RESearch.cxx (4) M scintilla/src/RunStyles.cxx (6) M scintilla/src/ScintillaBase.cxx (26) M scintilla/src/Style.cxx (6) M scintilla/src/UniConversion.cxx (16) M scintilla/src/UniConversion.h (1) M scintilla/src/ViewStyle.cxx (6) M scintilla/version.txt (2)
-- Patch Links --
https://github.com/geany/geany/pull/2045.patch https://github.com/geany/geany/pull/2045.diff
@BenWiederhake could you test this and see if it indeed fixes the 2 markdown issues mentioned above?
@b4n, That was fast, well done. WFM so far.
Hope it didn't stop you from reviewing @techee's ctags PR :grin:
## Before
geany 1.33 (built on 2018-04-16 with GTK 3.22.29, GLib 2.56.1) #971: Yes, can reproduce it, but file must be recognized as Markdown (e.g., save as "blahblah.md") #1947: Yes, can reproduce it, exactly as described.
## After
(I checked that at least "scintilla/include/Platform.h" contains the changes. `cat scintilla/version.txt` says 3102. The Debian patches seem mostly cosmetic for my purpose. Building with "auto" fails, wants gtk2-dev libs, complains about symbols and version mixing. `./configure --disable-html-docs --enable-gtk3 && make -j4 && sudo make install` Success.) geany 1.35 (git >= ecf98b1e) (built on 2019-01-13 with GTK 3.24.2, GLib 2.58.2) #971: No, can't reproduce it: Correct (fixed) initial state, and correct (fixed) behavior when pressing enter. *Looks fixed to me.* #1947: No, can't reproduce it: Correct (fixed) initial state, and correct (fixed) behavior when deleting a character. *Looks fixed to me.*
Less than 24 hours after the scintilla version appeared! Thank you for your quick work! :)
Merged #2045 into master.
@BenWiederhake thanks for the detailed check :)
github-comments@lists.geany.org