This was removed in e465a2b456e7c0aba6aefc1c4b406b8089386d1a erroneously but it still needed on Windows/mingw64 builds. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3600
-- Commit Summary --
* Link to libiconv explicitly for Windows/mingw64 builds
-- File Changes --
M configure.ac (1)
-- Patch Links --
https://github.com/geany/geany/pull/3600.patch https://github.com/geany/geany/pull/3600.diff
@elextr just for you, the classic last minute Windows fix.
This was removed as part of https://github.com/geany/geany/pull/3465 a few months ago. I was very sure I tested this properly but it turned out that the explicit link to `libiconv` is necessary for building on Windows. However it is not necessary for the cross compilation toolchain in the CI but also don't hurt.
@b4n approved this pull request.
You gotta do what you gotta do I guess
Merged #3600 into master.
github-comments@lists.geany.org