When the Find in Files path doesn't exist, the *status bar* says "Cannot execute grep tool...: Failed to change the working directory. Check the path setting in Preferences". Which is confusing and hides the real problem in the middle of irrelevant text. Instead, show a dialog with the correct error only.
Also show dialogs for no search text & bad search regex errors, rather than status bar messages. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3818
-- Commit Summary --
* Improve search errors
-- File Changes --
M src/search.c (11)
-- Patch Links --
https://github.com/geany/geany/pull/3818.patch https://github.com/geany/geany/pull/3818.diff
@ntrel pushed 1 commit.
5008163374fd233416f01d9d4369f2f6f3f4cb37 Fix FiF capitalization
@ntrel pushed 1 commit.
9e6062d7b7710d18523a7291ea6ed615fa99d25f Revert dialog errors
Agree, improving input validation is a better solution since the command return error does not actually identify the error.
LGBI
@ntrel pushed 1 commit.
4088e9e4a0998fab12496d80a84ffd5df9e53626 Set FIF search/directory entry background to indicate error
Merged #3818 into master.
github-comments@lists.geany.org