The mentioned file `scintilla/src/Catalogue.cxx` was removed in Scintilla/Lexilla v5 (7694aa5acb730fb7d0bbd1b4212140e63d315215) – maybe it's time to update the documentation? 😳 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3481
-- Commit Summary --
* HACKING: Update instructions for new lexer modules
-- File Changes --
M HACKING (2)
-- Patch Links --
https://github.com/geany/geany/pull/3481.patch https://github.com/geany/geany/pull/3481.diff
Need to add comment on #3480 about `scintilla_changes.patch`
@ntrel commented on this pull request.
@@ -588,7 +588,7 @@ LexFoo.cxx. Try the official Scintilla project first.
When adding a lexer, update:
* scintilla/Makefile.am
```suggestion * meson.build * scintilla/Makefile.am ```
@ntrel approved this pull request.
@elextr requested changes on this pull request.
@@ -588,7 +588,7 @@ LexFoo.cxx. Try the official Scintilla project first.
When adding a lexer, update:
* scintilla/Makefile.am -* scintilla/src/Catalogue.cxx - add a LINK_LEXER command *manually* +* scintilla/lexilla/src/Lexilla.cxx - add the lexer module in AddGeanyLexers()
Don't forget `scintilla-changes.patch`
@killerbees19 pushed 1 commit.
a55403c2ef966e908c816de6d7a33efcc542ab07 Update HACKING
I think something like that is already part of the updated HACKING. Closing.
Closed #3481.
github-comments@lists.geany.org