Addresses relevant issues mentioned in #1876. I didn't care about several "dead assignments", because they are initial values for variables, or make mirrors similar logic in the same function (like successive calls moving a pointer, I left the last one storing the move even if it's not (currently) used afterward), etc.
**:warning: WARNING :warning:** The Perl change should be checked by a Perl person, I don't really know if it actually makes sense to report this differently. Also, should be upstreamed if relevant. BTW, I can move this out of this PR. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1878
-- Commit Summary --
* Report subroutine declarations as such * Add a sanity check on the Save As callback * Remove an unnecessary local variable * Remove unused parameter
-- File Changes --
M ctags/parsers/perl.c (1) M src/dialogs.c (1) M src/editor.c (15) M src/editor.h (2) M src/keybindings.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/1878.patch https://github.com/geany/geany/pull/1878.diff
Yeah it'd be great to get stuff like the Perl change and #1820 and such upstreamed.
codebrainz approved this pull request.
I didn't test it but the changes look fine.
LGBI
Don't know the semantics of the Perl change either.
Merged #1878 into master.
I checked the upstream u-ctags Perl parser, and it does use the new kind value, so it should be fine.
github-comments@lists.geany.org