This patch: - adds a scripts/update-themes.py script copying themes with compatible licenses (themes with no explicit license are skipped for now) - copies these themes under data/colorschemes - adds lgpl-2.0.txt, lgpl-2.1.txt, gpl-3.0.txt to data/colorschemes to cover themes not falling under Geany'sGPL 2.0 or later
Fixes #4035. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4044
-- Commit Summary --
* Add themes from geany-themes
-- File Changes --
M data/Makefile.am (43) A data/colorschemes/abc-dark.conf (120) A data/colorschemes/abc-light.conf (120) A data/colorschemes/bespin.conf (121) A data/colorschemes/black.conf (125) A data/colorschemes/cyber-sugar.conf (135) A data/colorschemes/darcula.conf (149) A data/colorschemes/dark-colors.conf (136) A data/colorschemes/dark-fruit-salad.conf (121) A data/colorschemes/dark.conf (120) A data/colorschemes/delt-dark.conf (106) A data/colorschemes/earthsong.conf (120) A data/colorschemes/epsilon.conf (117) A data/colorschemes/evg-ega-dark.conf (148) A data/colorschemes/gedit.conf (120) A data/colorschemes/github.conf (122) A data/colorschemes/gpl-3.0.txt (674) A data/colorschemes/grey8.conf (116) A data/colorschemes/hacker.conf (116) A data/colorschemes/himbeere.conf (135) A data/colorschemes/inkpot.conf (118) A data/colorschemes/kugel.conf (132) A data/colorschemes/lgpl-2.0.txt (480) A data/colorschemes/lgpl-2.1.txt (501) A data/colorschemes/matcha.conf (130) A data/colorschemes/mc.conf (117) A data/colorschemes/metallic-bottle.conf (115) A data/colorschemes/notepad-plus-plus.conf (122) A data/colorschemes/oblivion2.conf (120) A data/colorschemes/one-dark.conf (148) A data/colorschemes/pygments.conf (131) A data/colorschemes/retro.conf (115) A data/colorschemes/sleepy-pastel.conf (102) A data/colorschemes/slushpoppies.conf (120) A data/colorschemes/solarized-dark.conf (147) A data/colorschemes/solarized-light.conf (147) A data/colorschemes/spyder-dark.conf (118) A data/colorschemes/steampunk.conf (123) A data/colorschemes/tango-light.conf (120) A data/colorschemes/tinge.conf (128) A data/colorschemes/ubuntu.conf (116) A data/colorschemes/vibrant-ink.conf (123) A scripts/update-themes.py (106)
-- Patch Links --
https://github.com/geany/geany/pull/4044.patch https://github.com/geany/geany/pull/4044.diff
Looks good, great!
To be more verbose: the licensing is annoying but the solution here using an allowlist is pretty good and it's nice that we already get almost all themes included.
Thanks for digging through all the themes and put up the list.
After we have merged this, we could add a note to the geany-themes repo's README to show that the themes with compatible license are included semi-automatically.
Is it worth adding a note to `doc/making-a-release`?
To be more verbose: the licensing is annoying but the solution here using an allowlist is pretty good and it's nice that we already get almost all themes included.
I just hope it's alright license-wise - for instance that a GPL 3 theme doesn't require that all Geany sources are GPL 3. But I'd say that since themes are completely independent of the rest of the Geany, loaded at the runtime in the source form, and non-essential for running Geany, they don't affect the license of Geany itself. Am I right?
After we have merged this, we could add a note to the geany-themes repo's README to show that the themes with compatible license are included semi-automatically.
Agree.
Is it worth adding a note to doc/making-a-release?
I'll try to update it.
I also created https://github.com/geany/geany-themes/pull/77 so geany-themes contains all the external theme files - I just don't know what to use as its license and who is the author of that theme.
@techee pushed 1 commit.
3442e6a9b16e7d85d208efe0828e9e793006ec27 Update doc/making-a-release
To be more verbose: the licensing is annoying but the solution here using an allowlist is pretty good and it's nice that we already get almost all themes included.
I just hope it's alright license-wise - for instance that a GPL 3 theme doesn't require that all Geany sources are GPL 3. But I'd say that since themes are completely independent of the rest of the Geany, loaded at the runtime in the source form, and non-essential for running Geany, they don't affect the license of Geany itself. Am I right?
I think yes but I'm not sure at all. @frlan do you know who we could ask? Someone from FSFE maybe?
Is it worth adding a note to doc/making-a-release?
I'll try to update it.
Thanks.
I also created [geany/geany-themes#77](https://github.com/geany/geany-themes/pull/77) so geany-themes contains all the external theme files - I just don't know what to use as its license and who is the author of that theme.
Great, I answered there.
I just hope it's alright license-wise - for instance that a GPL 3 theme doesn't require that all Geany sources are GPL 3. But I'd say that since themes are completely independent of the rest of the Geany, loaded at the runtime in the source form, and non-essential for running Geany, they don't affect the license of Geany itself. Am I right?
I think yes but I'm not sure at all.
On the other hand in the worst case scenario that theme licenses affect Geany's license as a whole, I think we only have to deal with a single theme - the GPLv3 theme `epsilon`. Based on
https://www.gnu.org/licenses/gpl-faq.en.html#AllCompatibility
LGPLv2.1 code can be either "copied" to GPLv2 (and the result is GPLv2) or "used as a library" without any restriction - not sure which of the two things we do with themes but we should be fine.
I also searched for the difference between LGPLv2 (which most of the themes use) and LGPLv2.1 and made a diff of those and it's mostly renaming it from "GNU Library General Public License" to "GNU Lesser General Public License" and some minor wording so I think the table above is valid for LGPLv2 too as well.
So I think for now I could just move the GPLv3 theme to the ignored ones and keep the rest - I believe we should be fine.
@techee pushed 1 commit.
0c4a7b3b13e993bb111b84c23123944958babefe Remove the epsilon theme for now
So in Fedora we have two packages, one called `geany` and one called `geany-themes`. I see problems coming when both packages are trying to install the same file. Not sure yet on how to solve this, my current idea is to add a functionality to disable this feature at build time. How do you think about this?
So in Fedora we have two packages, one called `geany` and one called `geany-themes`. I see problems coming when both packages are trying to install the same file. Not sure yet on how to solve this, my current idea is to add a functionality to disable this feature at build time. How do you think about this?
After this PR a seperate `geany-themes` package is probably not necessary anymore. Only the themes with incompatible or missing licenses will be missing but we can try to relicense resp. add missing licenses and then include those themes too.
When talking about distributions with `geany-themes` packages: how did you solve the licensing problem? @dmaphy @matt-h @Digital-Chaos
So in Fedora we have two packages, one called `geany` and one called `geany-themes`. I see problems coming when both packages are trying to install the same file. Not sure yet on how to solve this, my current idea is to add a functionality to disable this feature at build time. How do you think about this?
After this PR a seperate `geany-themes` package is probably not necessary anymore. Only the themes with incompatible or missing licenses will be missing but we can try to relicense resp. add missing licenses and then include those themes too.
Good, so the plan would be to obsolete the geany-themes package. That's something I can work with in Fedora. (:
When talking about distributions with `geany-themes` packages: how did you solve the licensing problem? @dmaphy @matt-h @Digital-Chaos
Just checked for the Fedora package. Most colorschemes there are (L)GPLv2+ or BSD licensed. Actually there could be issues with the `monokai.conf`, gotta clarify the situation or remove that one when I get around to it.
@techee pushed 2 commits.
01b8bf20c5fc1bacf934d80ab4febad1c35e1f5c Update licenses of alt.conf and kurayami.conf 9a62eb62b0d9aa32cc5879801f28e2d1643f5026 Warn when Geany contains more themes than geany-themes
(I accidentally pushed this 'themes' branch to the geany repo instead of my fork. I've already deleted this branch.)
@techee pushed 1 commit.
31a2c8d320d96d5f21937d9277e062763d66bcfe Add the kurayami theme itself
@techee pushed 1 commit.
6cf6c1ea8fe040d8181f2a5138adc446c469a972 Update license of epsilon and tango-dark themes and add them
eht16 left a comment (geany/geany#4044)
@techee in https://github.com/geany/geany-themes three new themes were added: - octagon.conf - carbonfox.conf - underthesea.conf
All licensed as GPLv3 or later.
We could add them here as well and then maybe actually merge?
techee left a comment (geany/geany#4044)
All licensed as GPLv3 or later.
What shall we do about GPLv3 themes? I was trying to avoid those because of the comment in
https://github.com/geany/geany/pull/4044#issuecomment-2483613593
and get some of the existing GPLv3 themes relicensed to GPLv2 or later (see https://github.com/geany/geany-themes/issues/79, https://github.com/geany/geany-themes/issues/80). Is it OK to add them to Geany which, as a whole, is licensed under GPLv2 or later?
eht16 left a comment (geany/geany#4044)
Sorry, I missed this.
I asked the author whether it is ok to change the license (https://github.com/geany/geany-themes/issues/84).
@techee pushed 1 commit.
81b0b8ad5ef4f2ee4dd9abb5731a43b31bd7182f Add carbonfox, octagon, underthesea themes
techee left a comment (geany/geany#4044)
@eht16 I've added the new themes. Is it OK to squash some of the commits?
eht16 left a comment (geany/geany#4044)
@eht16 I've added the new themes.
Cool, thanks.
Is it OK to squash some of the commits?
Sure, maybe even all into one.
techee left a comment (geany/geany#4044)
Sure, maybe even all into one.
Yep, done.
github-comments@lists.geany.org