closes #2054 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2058
-- Commit Summary --
* geany-status.m4:replace hyphens with text
-- File Changes --
M m4/geany-status.m4 (3)
-- Patch Links --
https://github.com/geany/geany/pull/2058.patch https://github.com/geany/geany/pull/2058.diff
code LGBI, but I would have said why you are removing the dashes "because seq isn't available on some BSDs" or similar, but that can go in the merge message
b4n commented on this pull request.
@@ -27,7 +27,8 @@ EOF
# Print a nice top bar # description + ' : ' + value total=`expr $dlen + 3 + $vlen` - for i in `seq 1 $total`; do printf '-'; done + echo + echo " Build configuration result:"
Sadly `printf '%-*s' $total '' | tr ' ' -` isn't portable…
But what about this? ```shell i=0; while test $i -lt $total; do printf '-'; i=`expr $i + 1`; done ```
elextr commented on this pull request.
@@ -27,7 +27,8 @@ EOF
# Print a nice top bar # description + ' : ' + value total=`expr $dlen + 3 + $vlen` - for i in `seq 1 $total`; do printf '-'; done + echo + echo " Build configuration result:"
what about echo "----------------------------------------"
thats guaranteed to be portable (and what configure.in had a long time ago :)
andy5995 commented on this pull request.
@@ -27,7 +27,8 @@ EOF
# Print a nice top bar # description + ' : ' + value total=`expr $dlen + 3 + $vlen` - for i in `seq 1 $total`; do printf '-'; done + echo + echo " Build configuration result:"
what about echo "----------------------------------------"
thats guaranteed to be portable (and what configure.in had a long time ago :)
That seems like a good choice, imo. Let me know when there's agreement and I'll make the change.
Pretty sure that #2060 from @b4n will be used instead. closing...
Closed #2058.
github-comments@lists.geany.org