Some time ago I posted an e-mail into the Geany-users mailing list asking for a keybinding for deleting from the begining of the line to the current position. I got some good answers and suggestions, and, some months later, here I come with the implementation ready to be used. I've tested it and it looks fine.
Anything else, just let me know. I didn't touch any of the translation files, should I? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1134
-- Commit Summary --
* Added keybinding for Delete from line start to current position
-- File Changes --
M doc/geany.txt (3) M src/keybindings.c (6) M src/keybindings.h (1)
-- Patch Links --
https://github.com/geany/geany/pull/1134.patch https://github.com/geany/geany/pull/1134.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134
I set <kbd>Cntrl</kbd> + <kbd>Shift</kbd> + <kbd>BackSpace</kbd> as default keybinding for the complementary relationship with "Delete to line End" shortcut. It is consistent with "delete previous word" and "delete next word" shortcuts.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232214485
LGBI
Extra points for doing the documentation :+1:
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232234186
Note: that keybinding is also what Scintilla uses by default for delete to start of line, so it is the correct choice.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232235827
See https://github.com/Akronix/geany/pull/1 for a few fixups, otherwise looks and works good for me.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232238812
Untested but LGBI
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232355430
Closed #1134 via 14904a18ff75926a75a648f55dcf71376cc2be23.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#event-722295376
@Akronix I squished my two commits into yours before merging since they're just small fixes.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232511370
@@ -185,6 +185,7 @@ enum GeanyKeyBindingID GEANY_KEYS_GOTO_TAGDEFINITION, /**< Keybinding. */ GEANY_KEYS_SEARCH_NEXTMESSAGE, /**< Keybinding. */ GEANY_KEYS_EDITOR_DELETELINETOEND, /**< Keybinding. */
- GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */
Wait. This enum is public, one must not add anything in the middle but only at the end. Right not it changes every following values, breaking API.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134/files/532fc12db70c5fa9c9ea5bb4ac7b3...
@@ -185,6 +185,7 @@ enum GeanyKeyBindingID GEANY_KEYS_GOTO_TAGDEFINITION, /**< Keybinding. */ GEANY_KEYS_SEARCH_NEXTMESSAGE, /**< Keybinding. */ GEANY_KEYS_EDITOR_DELETELINETOEND, /**< Keybinding. */
- GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */
Ok, I'll add another commit to fix.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134/files/532fc12db70c5fa9c9ea5bb4ac7b3...
@@ -185,6 +185,7 @@ enum GeanyKeyBindingID GEANY_KEYS_GOTO_TAGDEFINITION, /**< Keybinding. */ GEANY_KEYS_SEARCH_NEXTMESSAGE, /**< Keybinding. */ GEANY_KEYS_EDITOR_DELETELINETOEND, /**< Keybinding. */
- GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */
Fixed in 313b85a149dcb71940073062839087dd0245af04
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134/files/532fc12db70c5fa9c9ea5bb4ac7b3...
@@ -185,6 +185,7 @@ enum GeanyKeyBindingID GEANY_KEYS_GOTO_TAGDEFINITION, /**< Keybinding. */ GEANY_KEYS_SEARCH_NEXTMESSAGE, /**< Keybinding. */ GEANY_KEYS_EDITOR_DELETELINETOEND, /**< Keybinding. */
- GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */
Perfect :)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134/files/532fc12db70c5fa9c9ea5bb4ac7b3...
Thank you for all your reviews. I'm happy to have it there now :smile:
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1134#issuecomment-232518377
github-comments@lists.geany.org