Add support for webkit2gtk-4.1. Drop support for webkitgtk.
Related: #1295 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1335
-- Commit Summary --
* Markdown: Allow building with webkit2gtk-4.1 * Markdown: Remove webkitgtk support
-- File Changes --
M build/markdown.m4 (12) M markdown/src/Makefile.am (4) M markdown/src/viewer.c (33) M markdown/src/viewer.h (6)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1335.patch https://github.com/geany/geany-plugins/pull/1335.diff
LGBI, the removals look good but did not check thats all that needs removing.
Needs to update README
@xiota pushed 1 commit.
c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 Markdown: Update version numbers
@b4n commented on this pull request.
Looks good, works fine, but the 2 first commits don't really work one without the other, so they should be merged: the first one actually make it use webkit2gtk only, but by removes the conditional that enables the code to use it (and it probably also breaks the build system by having an undefined conditional).
So fine by me once those 2 commits get squashed together.
@b4n Thanks... I've squashed the commits.
@b4n approved this pull request.
LGTM and seems to work fine here.
Merged #1335 into master.
github-comments@lists.geany.org