Simple Asciidoc lexer following Asciidoctor recommended practiques:
https://asciidoctor.org/docs/asciidoc-recommended-practices/
Tested with Asciidoctor README.adoc file:
https://github.com/asciidoctor/asciidoctor/blob/main/README.adoc
With the next result: ![geany](https://user-images.githubusercontent.com/24474865/140573699-cb4739ed-98ad-4...)
PD: Sorry but GitHub doesn't allow to create PRs from a branch (ancebfer/geany 1.38.1) to a tag (geany/geany 1.38.0) as desired.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2986
-- Commit Summary --
* <a href="https://github.com/geany/geany/pull/2986/commits/9cb51e617b1b6355a7b360af7832103c34203388">Adds a simple Asciidoc lexer for Scintilla</a>
-- File Changes --
M data/filedefs/filetypes.asciidoc (50) M scintilla/Makefile.am (1) M scintilla/include/SciLexer.h (25) M scintilla/include/Scintilla.iface (27) A scintilla/lexers/LexAsciidoc.cxx (384) M scintilla/src/Catalogue.cxx (1) M src/highlighting.c (2) M src/highlightingmappings.h (33)
-- Patch Links --
https://github.com/geany/geany/pull/2986.patch https://github.com/geany/geany/pull/2986.diff
Geany is updating from Scintilla 3.5 used in 1.38 to Scintilla 5, currently 5.1.1 but probably 5.1.4 to be released in a few days. Your lexer needs to be built for that.
The Geany project does not maintain Scintilla or the lexers ourselves but send all issues and improvements upstream. The lexers are now separated into the Lexilla project so you need to submit it there (in github happily) and it can be added to Geany from there.
Following your recommendations, I have create a PR to Lexilla:
https://github.com/ScintillaOrg/lexilla/pull/39
Best regards.
El vie, 5 nov 2021 a las 23:55, elextr ***@***.***>) escribió:
Geany is updating from Scintilla 3.5 used in 1.38 to Scintilla 5, currently 5.1.1 but probably 5.1.4 to be released in a few days. Your lexer needs to be built for that.
The Geany project does not maintain Scintilla or the lexers ourselves but send all issues and improvements upstream. The lexers are now separated into the Lexilla project so you need to submit it there (in github happily) and it can be added to Geany from there.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geany/geany/pull/2986#issuecomment-962266765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2XJ4MXOUIZF4X4J74XWX3UKROF7ANCNFSM5HOX6ESQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
The Asciidoc lexer is now officially included in Lexilla 5.1.4
Please, let me now when Geany is updated to Lexilla 5.1.4 in order to update a new pull request.
See https://github.com/geany/geany/blob/master/scintilla/version.txt
Thanks, this is exactly what I need. I will monitor for changes in https://github.com/geany/geany/blob/master/scintilla/lexilla/version.txt
Closed #2986.
github-comments@lists.geany.org