Depends on #2301, that should be merged first. (Could be worked around if necessary).
Currently the user can manually edit `geany.conf` or the project `.conf` to add filetype-independent execute commands which silently override the filetype execute ones. It's not really explained in the manual (but Lex says it's in the Wiki page), my guess is it's not used much.
This creates a new group of build commands - independent execute commands. These appear in the build menu after the filetype execute commands. This is more flexible for the user and allows for adding GUI configurability to the 'Set Build Commands' dialog (which I can do in another pull). This adds a keybinding for the first filetype-independent execute command, which defaults to Shift+F5. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2307
-- Commit Summary --
* build.c: Replace return_cmd_if macros with simpler BREAK_IF_CMD macro * Replace unhygienic macro calls with array of struct * Begin separating filetype-independent execute commands from FT execute * Replace run_info with run_pids * load & save independent exec group instead of ft exec * Make build_run_cmd support independent execute & add keybinding * Show independent run menu items
-- File Changes --
M TODO (1) M src/build.c (232) M src/build.h (2) M src/keybindings.c (2) M src/keybindings.h (5)
-- Patch Links --
https://github.com/geany/geany/pull/2307.patch https://github.com/geany/geany/pull/2307.diff
@ntrel pushed 1 commit.
f1245bddc2877e2742ed6af6f38c6049745475d1 Allow overriding number of independent execute commands
I'm currently getting a segfault after editing the project filetype execute command, will investigate.
@ntrel pushed 1 commit.
f1f7fa15ce7ba702eea8936616cb8858e89418d5 Fix segfault after editing project filetype execute command
Fixed that but there are still bugs with the build commands dialog execute command.
The idea of adding another group of execute commands in the menu is fine.
But
(but Lex says it's in the Wiki page)
and https://github.com/geany/geany/issues/2274#issuecomment-533134153 sound like you made these major changes without actually reading how the current system works.
That does not inspire confidence.
Also since you say there are still bugs, its become common to add the WIP label or `[WIP]` to the title so people know its not yet ready.
sound like you made these major changes without actually reading how the current system works.
I have read the manual and the code. Are you saying the wiki is required reading?
Are you saying the wiki is required reading?
Yes, in the case where you are making changes to the way the program operates, then it is a professional approach to use all sources of information to understand the current operation.
@ntrel pushed 2 commits.
f31ee40d6c537232fb073048e836843437d7e8ca Use g_print for PRINTBUILDCMDS and add info 99eae3f4e85dc4b5d0c13b7335a8f5e7f125b012 Call build_remove_menu_item instead of manually clearing GeanyBuildCommand
@ntrel pushed 1 commit.
3241224b2ecae51e740be39a0889a3c2cfd979f1 More robust fix for uninitialized BuildDestination::dst
@ntrel pushed 2 commits.
4312ce3fb5e596ad8ee09f72260644118a6c723f docs: Clarify that "filetype & independent commands" mean build commands 98fa2d0893e8aa109de2a3e0a234148922d44b6e Update docs for independent execute
@ntrel pushed 1 commit.
837dbe1237cf3c3edafeda2b98d4e9645ea3cc50 Fix not saving project filetype execute commands after dialog editing
Update:
there are still bugs with the build commands dialog [project filetype] execute command
These have been fixed in the latest commit. The project filetype list (used for saving) was only updated if the *filetype build* commands had been edited. Now it's also updated if the (filetype) execute commands have been edited.
I've realised that this pull shouldn't really be merged to master until the commands dialog supports editing independent execute commands. This is because in master, with a project open, editing the dialog's execute field creates a project filetype-independent execute command. Although those commands are not lost with this pull, it would be confusing for them to no longer be visible in the dialog. So I suggest we merge this to a `geany/build-exec` branch until GUI editing of independent execute commands is implemented (in another pull for easier review).
BTW ATM Travis has failed due to an unrelated error: ``` The command "sudo apt-get update -qq" failed and exited with 100 during . ```
So I suggest we merge this to a geany/build-exec branch until GUI editing of independent execute commands is implemented (in another pull for easier review).
Sounds good to me, I support separate branches for large developments, its just that I'm not so sure how well it will get tested, but lets try.
Not sure what travis is whinging about for Linux builds, doesn't look like anything you did.
Not sure what travis is whinging about for Linux builds
Google says we need to add the key or use a newer Ubuntu version.
Merged #2307 into build-exec.
Fixed minor `doc/geany.txt` conflict, rebased and pushed to `geany/build-exec`.
github-comments@lists.geany.org