You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2347
-- Commit Summary --
* Iterate in tab order for *Close Other Documents*
-- File Changes --
M src/callbacks.c (11) M src/sidebar.c (1)
-- Patch Links --
https://github.com/geany/geany/pull/2347.patch https://github.com/geany/geany/pull/2347.diff
What is this PR doing or better said what is the advantage compared to the current code?
@LarsGit223 The existing code iterates documents_array sequentially. It's better for the user to iterate in notebook tab order, because tabs can be reordered. The user will notice the difference when there are unsaved documents to close.
Not sure if it matters, but I believe this will iterate back-to-front for users with RTL UI.
I believe this will iterate back-to-front for users with RTL UI
OK, looks like *Close All* has this same issue though: https://github.com/geany/geany/blob/master/src/document.c#L3372-L3380
I don't think this matters much, at least the order is still simple for the user to understand.
I don't think this matters much, at least the order is still simple for the user to understand.
Agree.
codebrainz commented on this pull request.
@@ -857,7 +857,6 @@ static void on_openfiles_document_action(GtkMenuItem *menuitem, gpointer user_da
while (i >= 0 && gtk_tree_model_iter_nth_child(model, &child, &iter, i)) { gtk_tree_model_get(model, &child, DOCUMENTS_DOCUMENT, &doc, -1); -
Should get rid of this change since it's unrelated and in another file.
codebrainz commented on this pull request.
@@ -857,7 +857,6 @@ static void on_openfiles_document_action(GtkMenuItem *menuitem, gpointer user_da
while (i >= 0 && gtk_tree_model_iter_nth_child(model, &child, &iter, i)) { gtk_tree_model_get(model, &child, DOCUMENTS_DOCUMENT, &doc, -1); -
Ah, I thought I had deja-vu when writing above comment, it was in #2346 that this came from I guess.
github-comments@lists.geany.org