At the moment, when "Always wrap search" and "Hide the find dialog" are disabled in preferences, after performing wrap and dismissing the wrap dialog, the editor is focused instead of the search/replace dialog again. This interrupts keyboard-based user interaction with the dialog as users have to manually re-focus the search/replace dialog.
I haven't found a way to re-focus the search/replace dialog without hiding it first. But I actually think hiding the search/replace dialog when the wrap dialog is shown is a cleaner UI than having the two dialogs on top of each other.
Fixes #4021. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/4096
-- Commit Summary --
* Move show_wrap_search_dialog() to search.h * Hide find/replace dialogs when wrap dialog is shown * Remove parent argument from document_find_text() and search_show_wrap_dialog()
-- File Changes --
M src/document.c (46) M src/document.h (2) M src/search.c (59) M src/search.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/4096.patch https://github.com/geany/geany/pull/4096.diff
@techee pushed 2 commits.
c9e93d8e4f943f6e55c1dd207182db452f0cb09f Hide find/replace dialogs when wrap dialog is shown b85e4adae6b5959d90ce8cc68588a6c1ea17599b Remove parent argument from document_find_text() and search_show_wrap_dialog()
@techee pushed 2 commits.
e171d2a1d764717d0b359feadfe4b90399f9735d Hide find/replace dialogs when wrap dialog is shown 4cf437f31c7133786642889214c7f48b1e35c935 Remove parent argument from document_find_text() and search_show_wrap_dialog()
github-comments@lists.geany.org