This will add some internal linking (Terminal/browser) ... we got an open PR waiting to add Genea to Haiku: https://github.com/haikuports/haikuports/pull/7078 I still haven't figured out an issue on the icons, but I'm sure someone in our team will get around to that.
I also added gtkspell to our ports and seems to be working OK in Geany
A PR for the plugins is atm still in progress but should be ready soon.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3242
-- Commit Summary --
* Add support for Haiku
-- File Changes --
M src/keyfile.c (7)
-- Patch Links --
https://github.com/geany/geany/pull/3242.patch https://github.com/geany/geany/pull/3242.diff
@elextr @kugel- @techee any opinions?
I don't know Haiku, it probably have a few powers of ten less users than Windows or macOS and so adding every niche OS feels weird. On the other hand, it's only five lines of settings.
Still, I would say it might be better for Haiku to patch their settings in as it is also done by other distros and OSes. Unlike Windows and macOS, the Haiku builds are not maintained by the Geany dev team.
I don't have a strong opinion here. The added code isn't something we'd have to actively maintain in any way so probably not a big problem for us.
Agree with Enrico that since other distros maintain their own patches to those settings defaults, thats really what Haiku should do.
Well, the "proper" solution probably is for all those defines to go in a separate `system-config.h` so OSes and distros can supply their own without patching and without thousands of nested `#ifdef`s but thats unlikely in the short term.
Thanks for looking into it, the patch is small enough to keep at our end if this doesn't get merged, a system-wide config file like @elextr mentions would help out also I guess. Haiku as an OS may have a small user group, but for IDE's lik Geany I think the current group is one to target (developers). Aside from that we are small but plenty around the world. :)
I basically agree with everyone, but with a couple additional remarks:
I really find the fonts choice odd: we really mean to have monospaced fonts *at least* in the editor. If somehow Haiku doesn't provide a sensible default for *monospace*, sure, use a specific one that makes sense there, but please keep it monospaced.
Otherwise, I think it depends on how *required* those settings are for the relevant options to work on Haiku or not. If for example Haiku ships with its own browser and using *firefox* will either virtually never work or feel out of place, sure. If it's a preference, not so much. So at a glance, I'd think that the default apps change make sense, but the fonts not so much.
@elextr's and @eht16's point of distros patching their favorite defaults make sense, but I see one main difference: we've got a preprocessor define to work with here, like we do for Windows and macos, whereas there's nothing similar for Debian/Fedora/Gentoo/Whatnot. This makes integrating those changes realistic (they only affect Haiku), whereas the ones from Linux distros's preferences would be a lot harder to integrate -- and probably a lot more questionable, and we can't anyway have a special case for everyone out there.
So again, I don't really care either way. I'm fine with having Haiku tweaks in even if we'd rely on actual users to contribute it (same as I'd be happy with *BSD tweaks if need be, or basically any other OS different enough to require it, virtually no matter the user base -- yet, don't make me say what I didn't, don't create a fresh OS just to add support here :wink:); just as I'm fine with these kind of defaults being left to the providers.
github-comments@lists.geany.org